Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2288103003: Enable HW encoding on Android. (Closed)

Created:
4 years, 3 months ago by sakal-chromium
Modified:
4 years, 3 months ago
CC:
avayvod+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, mlamouri+watch-media_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org, magjed_chromium
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable HW encoding on Android. This code has been in the code base for a very long time but it was never enabled. This CL fixes a small bug in it and enables it. BUG=445320, 638664 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/3890074de7f2607c0c6856ae6c85738e4a9e9d44 Cr-Commit-Position: refs/heads/master@{#419132}

Patch Set 1 : Changes #

Total comments: 1

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Patch Set 4 : Undo the changes in the MediaCodecBridge. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M gpu/config/software_rendering_list_json.cc View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M media/gpu/android_video_encode_accelerator.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 32 (23 generated)
sakal-chromium
https://codereview.chromium.org/2288103003/diff/20001/media/gpu/android_video_encode_accelerator.cc File media/gpu/android_video_encode_accelerator.cc (left): https://codereview.chromium.org/2288103003/diff/20001/media/gpu/android_video_encode_accelerator.cc#oldcode386 media/gpu/android_video_encode_accelerator.cc:386: RETURN_ON_FAILURE(false, "Unexpected output format change", This failure was added ...
4 years, 3 months ago (2016-08-29 10:46:23 UTC) #2
sakal-chromium
PTAL
4 years, 3 months ago (2016-09-12 12:03:06 UTC) #18
aelias_OOO_until_Jul13
lgtm
4 years, 3 months ago (2016-09-13 02:32:10 UTC) #21
watk
lgtm
4 years, 3 months ago (2016-09-13 17:58:40 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2288103003/80001
4 years, 3 months ago (2016-09-15 11:54:43 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/293727)
4 years, 3 months ago (2016-09-15 13:11:34 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2288103003/80001
4 years, 3 months ago (2016-09-16 07:03:24 UTC) #28
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 3 months ago (2016-09-16 08:36:57 UTC) #30
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 08:39:28 UTC) #32
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3890074de7f2607c0c6856ae6c85738e4a9e9d44
Cr-Commit-Position: refs/heads/master@{#419132}

Powered by Google App Engine
This is Rietveld 408576698