|
|
Created:
4 years, 3 months ago by sakal-chromium Modified:
4 years, 3 months ago CC:
avayvod+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, mlamouri+watch-media_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org, magjed_chromium Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnable HW encoding on Android. This code has been in the code base for a very long time but it was never enabled. This CL fixes a small bug in it and enables it.
BUG=445320, 638664
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/3890074de7f2607c0c6856ae6c85738e4a9e9d44
Cr-Commit-Position: refs/heads/master@{#419132}
Patch Set 1 : Changes #
Total comments: 1
Patch Set 2 : Rebase. #Patch Set 3 : Rebase. #Patch Set 4 : Undo the changes in the MediaCodecBridge. #
Messages
Total messages: 32 (23 generated)
Description was changed from ========== WIP: Enable HW VP8 encoding on Android. BUG=445320 ========== to ========== WIP: Enable HW VP8 encoding on Android. BUG=445320 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
https://codereview.chromium.org/2288103003/diff/20001/media/gpu/android_video... File media/gpu/android_video_encode_accelerator.cc (left): https://codereview.chromium.org/2288103003/diff/20001/media/gpu/android_video... media/gpu/android_video_encode_accelerator.cc:386: RETURN_ON_FAILURE(false, "Unexpected output format change", This failure was added by mistake in this CL https://codereview.chromium.org/1681613002. Previously it checked if the output buffers are big enough and not just always fail.
Patchset #1 (id:1) has been deleted
Description was changed from ========== WIP: Enable HW VP8 encoding on Android. BUG=445320 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== WIP: Enable HW VP8 encoding on Android. BUG=445320, 638664 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by sakal@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by sakal@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sakal@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== WIP: Enable HW VP8 encoding on Android. BUG=445320, 638664 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Enable HW encoding on Android. BUG=445320, 638664 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Enable HW encoding on Android. BUG=445320, 638664 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Enable HW encoding on Android. This code has been in the code base for a very long time but it was never enabled. This CL fixes a small bug in it and enables it. BUG=445320, 638664 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
sakal@chromium.org changed reviewers: + aelias@chromium.org, watk@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
lgtm
The CQ bit was checked by sakal@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by sakal@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Enable HW encoding on Android. This code has been in the code base for a very long time but it was never enabled. This CL fixes a small bug in it and enables it. BUG=445320, 638664 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Enable HW encoding on Android. This code has been in the code base for a very long time but it was never enabled. This CL fixes a small bug in it and enables it. BUG=445320, 638664 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #4 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Enable HW encoding on Android. This code has been in the code base for a very long time but it was never enabled. This CL fixes a small bug in it and enables it. BUG=445320, 638664 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Enable HW encoding on Android. This code has been in the code base for a very long time but it was never enabled. This CL fixes a small bug in it and enables it. BUG=445320, 638664 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/3890074de7f2607c0c6856ae6c85738e4a9e9d44 Cr-Commit-Position: refs/heads/master@{#419132} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/3890074de7f2607c0c6856ae6c85738e4a9e9d44 Cr-Commit-Position: refs/heads/master@{#419132} |