Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Unified Diff: media/gpu/android_video_encode_accelerator.h

Issue 2358683002: Android: enable/disable WebRTC HW H264 with a flag. (Closed)
Patch Set: loop codecs in fineHWEncoder() and other fixes. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/gpu/android_video_encode_accelerator.h
diff --git a/media/gpu/android_video_encode_accelerator.h b/media/gpu/android_video_encode_accelerator.h
index ce0fb704ec7ec7aa3a712eaa88690c3f82153aff..c00b16fdf4469b6d67da2cb83fb21400415f2719 100644
--- a/media/gpu/android_video_encode_accelerator.h
+++ b/media/gpu/android_video_encode_accelerator.h
@@ -55,7 +55,9 @@ class MEDIA_GPU_EXPORT AndroidVideoEncodeAccelerator
enum {
// Arbitrary choice.
INITIAL_FRAMERATE = 30,
watk 2016/10/01 01:06:54 Should this just be called FRAMERATE? Not sure why
braveyao 2016/10/03 23:50:15 Because this value is for initializing encoder onl
- // Until there are non-realtime users, no need for unrequested I-frames.
+ // Default I-Frame interval in seconds.
+ IFRAME_INTERVAL_H264 = 20,
+ IFRAME_INTERVAL_VPX = 100,
IFRAME_INTERVAL = INT32_MAX,
};
@@ -93,9 +95,8 @@ class MEDIA_GPU_EXPORT AndroidVideoEncodeAccelerator
// The difference between number of buffers queued & dequeued at the codec.
int32_t num_buffers_at_codec_;
- // A monotonically-growing value, used as a fake timestamp just to keep things
- // appearing to move forward.
- base::TimeDelta fake_input_timestamp_;
+ // A monotonically-growing value in us.
watk 2016/10/01 01:06:54 delete "in us". TimeDelta knows its units.
braveyao 2016/10/03 23:50:15 Done.
+ base::TimeDelta input_timestamp_;
// Resolution of input stream. Set once in initialization and not allowed to
// change after.

Powered by Google App Engine
This is Rietveld 408576698