Android: enable/disable WebRTC HW H264 with a flag.

media/gpu/android_video_encode_accelerator.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_GPU_ANDROID_VIDEO_ENCODE_ACCELERATOR_H_
 #define MEDIA_GPU_ANDROID_VIDEO_ENCODE_ACCELERATOR_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 36 matching lines @@
   void Encode(const scoped_refptr<VideoFrame>& frame,
               bool force_keyframe) override;
   void UseOutputBitstreamBuffer(const BitstreamBuffer& buffer) override;
   void RequestEncodingParametersChange(uint32_t bitrate,
                                        uint32_t framerate) override;
   void Destroy() override;
 
  private:
   enum {
     // Arbitrary choice.
     INITIAL_FRAMERATE = 30,

[watk, 2016/10/01 01:06:54]

Should this just be called FRAMERATE? Not sure why it's INITIAL

[braveyao, 2016/10/03 23:50:15]

Because this value is for initializing encoder only. The real bitrate and
framerate will vary according to BWE. It's common in WebRtc for both HW and SW
codecs. I suppose it's OK to keep it. 

-    // Until there are non-realtime users, no need for unrequested I-frames.
+    // Default I-Frame interval in seconds.
+    IFRAME_INTERVAL_H264 = 20,
+    IFRAME_INTERVAL_VPX = 100,
     IFRAME_INTERVAL = INT32_MAX,
   };
 
   // Impedance-mismatch fixers: MediaCodec is a poll-based API but VEA is a
   // push-based API; these methods turn the crank to make the two work together.
   void DoIOTask();
   void QueueInput();
   void DequeueOutput();
 
   // Start & stop |io_timer_| if the time seems right.
@@ skipping 17 matching lines @@
   typedef std::queue<std::tuple<scoped_refptr<VideoFrame>, bool, base::Time>>
       PendingFrames;
   PendingFrames pending_frames_;
 
   // Repeating timer responsible for draining pending IO to the codec.
   base::RepeatingTimer io_timer_;
 
   // The difference between number of buffers queued & dequeued at the codec.
   int32_t num_buffers_at_codec_;
 
-  // A monotonically-growing value, used as a fake timestamp just to keep things
-  // appearing to move forward.
-  base::TimeDelta fake_input_timestamp_;
+  // A monotonically-growing value in us.

[watk, 2016/10/01 01:06:54]

delete "in us". TimeDelta knows its units.

[braveyao, 2016/10/03 23:50:15]

Done.

+  base::TimeDelta input_timestamp_;
 
   // Resolution of input stream. Set once in initialization and not allowed to
   // change after.
   gfx::Size frame_size_;
 
   uint32_t last_set_bitrate_;  // In bps.
 
   DISALLOW_COPY_AND_ASSIGN(AndroidVideoEncodeAccelerator);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_GPU_ANDROID_VIDEO_ENCODE_ACCELERATOR_H_