Issue 23586002: New warning -> new pattern for fingers to learn for asserting failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23586002: New warning -> new pattern for fingers to learn for asserting failure. (Closed)

Created:
7 years, 3 months ago by mtklein

Modified:
7 years, 3 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

New warning -> new pattern for fingers to learn for asserting failure. The Ubuntu Clang compile bot has a warning enabled now that yells about !"foo" before it breaks Chrome's build where the same warning is -Werror. BUG= R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=10937

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	tests/DrawPathTest.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mtklein

7 years, 3 months ago (2013-08-27 16:15:45 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r10937 (presubmit successful).

Expand Messages | Collapse Messages