Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: tests/DrawPathTest.cpp

Issue 23586002: New warning -> new pattern for fingers to learn for asserting failure. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/DrawPathTest.cpp
diff --git a/tests/DrawPathTest.cpp b/tests/DrawPathTest.cpp
index 72ec1581676f25a543e4e40e10dda1e8c3565ad9..f47b8c36363d31000b65c10091f8e89ab15185d1 100644
--- a/tests/DrawPathTest.cpp
+++ b/tests/DrawPathTest.cpp
@@ -50,7 +50,7 @@ static void test_big_aa_rect(skiatest::Reporter* reporter) {
if (canvas->readPixels(&output, x, y)) {
REPORTER_ASSERT(reporter, 0 == pixel[0]);
} else {
- REPORTER_ASSERT(reporter, !"readPixels failed");
+ REPORTER_ASSERT_MESSAGE(reporter, false, "readPixels failed");
}
SkPaint paint;
@@ -65,7 +65,7 @@ static void test_big_aa_rect(skiatest::Reporter* reporter) {
// appear the same.
REPORTER_ASSERT(reporter, 0xFFFFFFFF == pixel[0]);
} else {
- REPORTER_ASSERT(reporter, !"readPixels failed");
+ REPORTER_ASSERT_MESSAGE(reporter, false, "readPixels failed");
}
surf->unref();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698