Protect some definitions in about_flags.cc with #defined(USE_ASH)

Protect some definitions in about_flags.cc with #defined(USE_ASH)

kAshMaterialDesignChoices, kAshMaxWindowsToUseMaskInOverviewChoices
and kAshMaxWindowsToUseShapeInOverviewChoices are currently only defined
when OS_CHROMEOS is true but they are actually only used when USE_ASH is
true. This CL protect the definitions with USE_ASH instead of
OS_CHROMEOS.

BUG=None

Committed: https://crrev.com/a9452aeef71e5bba5f14467200d63c60209a9c6d
Cr-Commit-Position: refs/heads/master@{#424125}

[fwang, 2016-09-20 11:30:53]

Description was changed from

==========
Protect some definitions in about_flags.cc with #defined(USE_ASH)

kAshMaterialDesignChoices, kAshMaxWindowsToUseMaskInOverviewChoices
and kAshMaxWindowsToUseShapeInOverviewChoices are currently only defined
when OS_CHROMEOS is true but they are actually only used when USE_ASH is
true. This CL protect the definitions with USE_ASH instead of
OS_CHROMEOS.

BUG=None
==========

to

==========
Protect some definitions in about_flags.cc with #defined(USE_ASH)

kAshMaterialDesignChoices, kAshMaxWindowsToUseMaskInOverviewChoices
and kAshMaxWindowsToUseShapeInOverviewChoices are currently only defined
when OS_CHROMEOS is true but they are actually only used when USE_ASH is
true. This CL protect the definitions with USE_ASH instead of
OS_CHROMEOS.

BUG=None
==========

[fwang, 2016-09-20 11:34:42]

fwang@igalia.com changed reviewers:
+ oshima@chromium.org

[fwang, 2016-09-20 18:57:39]

PTAL

[fwang, 2016-09-21 15:52:16]

fwang@igalia.com changed reviewers:
+ sky@chromium.org

[oshima, 2016-09-27 23:30:47]

lgtm

[sky, 2016-09-28 00:22:42]

LGTM

[fwang, 2016-09-28 06:36:18]

The CQ bit was checked by fwang@igalia.com

[commit-bot: I haz the power, 2016-09-28 06:36:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 06:38:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 06:38:22]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[fwang, 2016-10-04 12:53:34]

The CQ bit was checked by fwang@igalia.com

[commit-bot: I haz the power, 2016-10-04 12:53:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 12:56:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 12:56:12]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[fwang, 2016-10-10 09:28:20]

On 2016/10/04 12:56:12, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
>   mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

OK, it seems that AshMaxWindowsToUseMaskInOverviewChoices and
kAshMaxWindowsToUseShapeInOverviewChoices have been removed so I'll update the
patch to only deal with kAshMaterialDesignChoices.

[fwang, 2016-10-10 09:32:39]

The CQ bit was checked by fwang@igalia.com

[fwang, 2016-10-10 09:32:40]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2358573002/#ps20001
(title: "Protect kAshMaterialDesignChoices in about_flags.cc with
#defined(USE_ASH)")

[commit-bot: I haz the power, 2016-10-10 09:32:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 10:27:03]

Description was changed from

==========
Protect some definitions in about_flags.cc with #defined(USE_ASH)

kAshMaterialDesignChoices, kAshMaxWindowsToUseMaskInOverviewChoices
and kAshMaxWindowsToUseShapeInOverviewChoices are currently only defined
when OS_CHROMEOS is true but they are actually only used when USE_ASH is
true. This CL protect the definitions with USE_ASH instead of
OS_CHROMEOS.

BUG=None
==========

to

==========
Protect some definitions in about_flags.cc with #defined(USE_ASH)

kAshMaterialDesignChoices, kAshMaxWindowsToUseMaskInOverviewChoices
and kAshMaxWindowsToUseShapeInOverviewChoices are currently only defined
when OS_CHROMEOS is true but they are actually only used when USE_ASH is
true. This CL protect the definitions with USE_ASH instead of
OS_CHROMEOS.

BUG=None
==========

[commit-bot: I haz the power, 2016-10-10 10:27:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-10 10:28:56]

Description was changed from

==========
Protect some definitions in about_flags.cc with #defined(USE_ASH)

kAshMaterialDesignChoices, kAshMaxWindowsToUseMaskInOverviewChoices
and kAshMaxWindowsToUseShapeInOverviewChoices are currently only defined
when OS_CHROMEOS is true but they are actually only used when USE_ASH is
true. This CL protect the definitions with USE_ASH instead of
OS_CHROMEOS.

BUG=None
==========

to

==========
Protect some definitions in about_flags.cc with #defined(USE_ASH)

kAshMaterialDesignChoices, kAshMaxWindowsToUseMaskInOverviewChoices
and kAshMaxWindowsToUseShapeInOverviewChoices are currently only defined
when OS_CHROMEOS is true but they are actually only used when USE_ASH is
true. This CL protect the definitions with USE_ASH instead of
OS_CHROMEOS.

BUG=None

Committed: https://crrev.com/a9452aeef71e5bba5f14467200d63c60209a9c6d
Cr-Commit-Position: refs/heads/master@{#424125}
==========

[commit-bot: I haz the power, 2016-10-10 10:28:57]

Patchset 2 (id:??) landed as
https://crrev.com/a9452aeef71e5bba5f14467200d63c60209a9c6d
Cr-Commit-Position: refs/heads/master@{#424125}