Site Settings Desktop: Fix crash when deleting storage for a site.

chrome/browser/ui/webui/settings/site_settings_handler.cc

Index: chrome/browser/ui/webui/settings/site_settings_handler.cc
diff --git a/chrome/browser/ui/webui/settings/site_settings_handler.cc b/chrome/browser/ui/webui/settings/site_settings_handler.cc
index 90f2b508f7b82ece96fd8a309d3654a832afd331..bb0f9368a238fe978acb16ffdd752420dbb7e2d6 100644
--- a/chrome/browser/ui/webui/settings/site_settings_handler.cc
+++ b/chrome/browser/ui/webui/settings/site_settings_handler.cc
@@ -320,8 +320,8 @@ void SiteSettingsHandler::HandleClearUsage(
   CHECK_EQ(2U, args->GetSize());
   std::string origin;
   CHECK(args->GetString(0, &origin));
-  std::string type;
-  CHECK(args->GetString(1, &type));
+  double storage_type;
+  CHECK(args->GetDouble(1, &storage_type));

[Finnur, 2016/09/20 11:37:27]

This was the source of the crash. When I checked the code in 
initially, I was reading a double here but in a subsequent CL
(that converted the content settings enum to string) I accidentally 
changed this to GetString (mistakenly thinking this was a 
content settings type). But this is a storage type -- as should be 
obvious now.

[dschuyler, 2016/09/20 18:28:51]

Would it be ok to GetInteger here instead of GetDouble?

[Dan Beam, 2016/09/20 19:01:59]

I don't think that will work

 
   GURL url(origin);
   if (url.is_valid()) {
@@ -332,8 +332,7 @@ void SiteSettingsHandler::HandleClearUsage(
         = new StorageInfoFetcher(profile_);
     storage_info_fetcher->ClearStorage(
         url.host(),
-        static_cast<storage::StorageType>(static_cast<int>(
-            site_settings::ContentSettingsTypeFromGroupName(type))),
+        static_cast<storage::StorageType>(static_cast<int>(storage_type)),
         base::Bind(&SiteSettingsHandler::OnUsageInfoCleared,
             base::Unretained(this)));