Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3146)

Unified Diff: chrome/browser/resources/settings/site_settings/site_details.js

Issue 2358563002: Site Settings Desktop: Fix crash when deleting storage for a site. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/site_settings/site_details.js
diff --git a/chrome/browser/resources/settings/site_settings/site_details.js b/chrome/browser/resources/settings/site_settings/site_details.js
index 1fb2d4b1d87301c8b70a2bf805fa539aebcd033f..125e163823c78e5909ef384cb2f232859cacffdd 100644
--- a/chrome/browser/resources/settings/site_settings/site_details.js
+++ b/chrome/browser/resources/settings/site_settings/site_details.js
@@ -75,14 +75,15 @@ Polymer({
* Clears all data stored for the current origin.
*/
onClearStorage_: function() {
- this.$.usageApi.clearUsage(this.site.origin, this.storageType_);
+ this.$.usageApi.clearUsage(
+ this.toUrl(this.site.origin).href, this.storageType_);
Finnur 2016/09/20 11:37:27 I found while testing this, that if patterns are e
},
/**
* Called when usage has been deleted for an origin.
*/
onUsageDeleted: function(event) {
- if (event.detail.origin == this.site.origin) {
+ if (event.detail.origin == this.toUrl(this.site.origin).href) {
Finnur 2016/09/20 11:37:27 And when the delete-complete event comes in, we ne
this.storedData_ = '';
this.navigateBackIfNoData_();
}

Powered by Google App Engine
This is Rietveld 408576698