Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2358373002: [stubs] KeyedLoadIC_Megamorphic: inline fast-property lookups (Closed)

Created:
4 years, 3 months ago by Jakob Kummerow
Modified:
4 years, 3 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] KeyedLoadIC_Megamorphic: inline fast-property lookups Megamorphic keyed loads often load fast properties from the receiver (as opposed to its prototype chain). They should avoid polluting the stub cache for this. Drive-by fix: --trace-ic printed two identical log lines for KeyedLoadIC misses taking the LoadIC::Load path. Committed: https://crrev.com/a767d8f956f5aa51dda4e325188610e1cbfc1b6f Cr-Commit-Position: refs/heads/master@{#39684}

Patch Set 1 #

Patch Set 2 : refactor #

Patch Set 3 : rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -46 lines) Patch
M src/code-stub-assembler.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 1 5 chunks +82 lines, -42 lines 2 comments Download
M src/ic/ic.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
Jakob Kummerow
PTAL. https://codereview.chromium.org/2358373002/diff/40001/src/code-stub-assembler.cc File src/code-stub-assembler.cc (left): https://codereview.chromium.org/2358373002/diff/40001/src/code-stub-assembler.cc#oldcode4401 src/code-stub-assembler.cc:4401: Comment("stub cache probe for fast property load"); All ...
4 years, 3 months ago (2016-09-22 22:28:55 UTC) #4
Igor Sheludko
lgtm
4 years, 3 months ago (2016-09-23 16:08:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2358373002/40001
4 years, 3 months ago (2016-09-23 17:09:00 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-23 17:39:01 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 17:39:24 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a767d8f956f5aa51dda4e325188610e1cbfc1b6f
Cr-Commit-Position: refs/heads/master@{#39684}

Powered by Google App Engine
This is Rietveld 408576698