[stubs] KeyedLoadIC_Megamorphic: support getters

[stubs] KeyedLoadIC_Megamorphic: support getters

This extends the KeyedLoadIC_Megamorphic stub to call getters it found
on the receiver without falling back to a runtime call.

Committed: https://crrev.com/c636334829065d5ff5fb064693655e6db6444afd
Cr-Commit-Position: refs/heads/master@{#39688}

[Jakob Kummerow, 2016-09-23 01:38:54]

jkummerow@chromium.org changed reviewers:
+ ishell@chromium.org

[Jakob Kummerow, 2016-09-23 01:38:55]

PTAL. Reusing some existing code to take care of a TODO :-)

https://codereview.chromium.org/2362453004/diff/1/src/builtins/builtins.h
File src/builtins/builtins.h (left):

https://codereview.chromium.org/2362453004/diff/1/src/builtins/builtins.h#old...
src/builtins/builtins.h:54: TFS(KeyedLoadIC_Megamorphic_TF, KEYED_LOAD_IC,
kNoExtraICState,             \
For calling accessors, these builtins need to be generated after
Call_ReceiverIsAny.

https://codereview.chromium.org/2362453004/diff/1/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2362453004/diff/1/src/code-stub-assembler.cc#...
src/code-stub-assembler.cc:3159: void
CodeStubAssembler::ReturnValueOrCallGetter(Variable* var_value,
This is pulled out from below, unchanged.

[Igor Sheludko, 2016-09-23 07:11:25]

lgtm modulo suggestion:

https://codereview.chromium.org/2362453004/diff/1/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2362453004/diff/1/src/code-stub-assembler.cc#...
src/code-stub-assembler.cc:3159: void
CodeStubAssembler::ReturnValueOrCallGetter(Variable* var_value,
I have a feeling that with the following signature this function will be more
suitable for reuse:
  Node* CallGetterIfAccessor(Node* value, Node* details, Node* context, Node*
receiver, Label* if_bailout) {
    ...
    Bind(&done);
    return var_value.value();
  }

You can create another var_value inside. WDYT?

At least the details should be passed here as Node*.

[Jakob Kummerow, 2016-09-23 18:12:23]

Thanks, landing.

https://codereview.chromium.org/2362453004/diff/1/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2362453004/diff/1/src/code-stub-assembler.cc#...
src/code-stub-assembler.cc:3159: void
CodeStubAssembler::ReturnValueOrCallGetter(Variable* var_value,
On 2016/09/23 07:11:24, Igor Sheludko wrote:
> I have a feeling that with the following signature this function will be more
> suitable for reuse:
>   Node* CallGetterIfAccessor(Node* value, Node* details, Node* context, Node*
> receiver, Label* if_bailout) {
>     ...
>     Bind(&done);
>     return var_value.value();
>   }
> 
> You can create another var_value inside. WDYT?
> 
> At least the details should be passed here as Node*.

Done.

[Jakob Kummerow, 2016-09-23 18:13:52]

The CQ bit was checked by jkummerow@chromium.org

[Jakob Kummerow, 2016-09-23 18:13:53]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/2362453004/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-23 18:14:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 18:48:10]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-23 18:48:30]

Description was changed from

==========
[stubs] KeyedLoadIC_Megamorphic: support getters

This extends the KeyedLoadIC_Megamorphic stub to call getters it found
on the receiver without falling back to a runtime call.
==========

to

==========
[stubs] KeyedLoadIC_Megamorphic: support getters

This extends the KeyedLoadIC_Megamorphic stub to call getters it found
on the receiver without falling back to a runtime call.

Committed: https://crrev.com/c636334829065d5ff5fb064693655e6db6444afd
Cr-Commit-Position: refs/heads/master@{#39688}
==========

[commit-bot: I haz the power, 2016-09-23 18:48:31]

Patchset 3 (id:??) landed as
https://crrev.com/c636334829065d5ff5fb064693655e6db6444afd
Cr-Commit-Position: refs/heads/master@{#39688}