DevTools: extract a component for layer viewer

DevTools: extract a component for layer viewer

This lets the layer view to be reused without bringing the entire Timeline
panel as a dependency. Also, made all component widgets of the layer viewer
to be web components.

Committed: https://crrev.com/cc74cc44621d6771dc6fc15de0ecca1752a1b222
Cr-Commit-Position: refs/heads/master@{#420565}

[caseq, 2016-09-21 20:52:46]

caseq@chromium.org changed reviewers:
+ pfeldman@chromium.org

[caseq, 2016-09-22 00:15:07]

Description was changed from

==========
DevTools: extract a component for layer viewer

This lets the layer view to be reused without bringing the entire Timeline
panel as a dependency. Also, made all component widgets of the layer viewer
to be web components.
==========

to

==========
DevTools: extract a component for layer viewer

This lets the layer view to be reused without bringing the entire Timeline
panel as a dependency. Also, made all component widgets of the layer viewer
to be web components.
==========

[caseq, 2016-09-22 00:15:07]

caseq@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2016-09-22 16:35:35]

https://codereview.chromium.org/2358253002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/layer_viewer/PaintProfilerView.js
(right):

https://codereview.chromium.org/2358253002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/layer_viewer/PaintProfilerView.js:38:
WebInspector.HBox.call(this);
Turn into web component as well?

https://codereview.chromium.org/2358253002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/layer_viewer/layerDetailsView.css
(right):

https://codereview.chromium.org/2358253002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/layer_viewer/layerDetailsView.css:1:
table td {
Missing copyright.

https://codereview.chromium.org/2358253002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/layer_viewer/layers3DView.css
(right):

https://codereview.chromium.org/2358253002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/layer_viewer/layers3DView.css:1:
.layers-3d-view {
Missing copyright.

https://codereview.chromium.org/2358253002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/layer_viewer/paintProfiler.css
(right):

https://codereview.chromium.org/2358253002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/layer_viewer/paintProfiler.css:1:
.profiler-log-view {
Missing copyright.

https://codereview.chromium.org/2358253002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/layer_viewer/paintProfiler.css:4:
.paint-profiler-overview .banner {
nit: empty line before selector

https://codereview.chromium.org/2358253002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/layers/module.json (right):

https://codereview.chromium.org/2358253002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/layers/module.json:23:
"layersPanel.css"
This file is missing.

[caseq, 2016-09-23 00:01:43]

Patchset #2 (id:20001) has been deleted

[caseq, 2016-09-23 00:12:18]

ptal.

On 2016/09/22 16:35:35, dgozman wrote:
>
https://codereview.chromium.org/2358253002/diff/1/third_party/WebKit/Source/d...
> File
> third_party/WebKit/Source/devtools/front_end/layer_viewer/PaintProfilerView.js
> (right):
> 
>
https://codereview.chromium.org/2358253002/diff/1/third_party/WebKit/Source/d...
>
third_party/WebKit/Source/devtools/front_end/layer_viewer/PaintProfilerView.js:38:
> WebInspector.HBox.call(this);
> Turn into web component as well?

Done.

>
https://codereview.chromium.org/2358253002/diff/1/third_party/WebKit/Source/d...
> File
> third_party/WebKit/Source/devtools/front_end/layer_viewer/layerDetailsView.css
> (right):
> 
>
https://codereview.chromium.org/2358253002/diff/1/third_party/WebKit/Source/d...
>
third_party/WebKit/Source/devtools/front_end/layer_viewer/layerDetailsView.css:1:
> table td {
> Missing copyright.

Ouch. Fixed!

>
https://codereview.chromium.org/2358253002/diff/1/third_party/WebKit/Source/d...
> File
third_party/WebKit/Source/devtools/front_end/layer_viewer/layers3DView.css
> (right):
> 
>
https://codereview.chromium.org/2358253002/diff/1/third_party/WebKit/Source/d...
> third_party/WebKit/Source/devtools/front_end/layer_viewer/layers3DView.css:1:
> .layers-3d-view {
> Missing copyright.

Fixed!

> 
>
https://codereview.chromium.org/2358253002/diff/1/third_party/WebKit/Source/d...
> File
third_party/WebKit/Source/devtools/front_end/layer_viewer/paintProfiler.css
> (right):
> 
>
https://codereview.chromium.org/2358253002/diff/1/third_party/WebKit/Source/d...
> third_party/WebKit/Source/devtools/front_end/layer_viewer/paintProfiler.css:1:
> .profiler-log-view {
> Missing copyright.

Fixed!

>
https://codereview.chromium.org/2358253002/diff/1/third_party/WebKit/Source/d...
> third_party/WebKit/Source/devtools/front_end/layer_viewer/paintProfiler.css:4:
> .paint-profiler-overview .banner {
> nit: empty line before selector

This is gone now.

>
https://codereview.chromium.org/2358253002/diff/1/third_party/WebKit/Source/d...
> File third_party/WebKit/Source/devtools/front_end/layers/module.json (right):
> 
>
https://codereview.chromium.org/2358253002/diff/1/third_party/WebKit/Source/d...
> third_party/WebKit/Source/devtools/front_end/layers/module.json:23:
> "layersPanel.css"
> This file is missing.

Gone as well :)

[dgozman, 2016-09-23 00:40:06]

lgtm

https://codereview.chromium.org/2358253002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css
(right):

https://codereview.chromium.org/2358253002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css:296: .banner
a {
At least rename this to more specific selector like "full-widget-dimmed-banner"
or something.

[caseq, 2016-09-23 01:46:27]

The CQ bit was checked by caseq@chromium.org

[caseq, 2016-09-23 01:46:27]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2358253002/#ps60001
(title: "renamed the banner")

[commit-bot: I haz the power, 2016-09-23 01:46:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 03:21:45]

Description was changed from

==========
DevTools: extract a component for layer viewer

This lets the layer view to be reused without bringing the entire Timeline
panel as a dependency. Also, made all component widgets of the layer viewer
to be web components.
==========

to

==========
DevTools: extract a component for layer viewer

This lets the layer view to be reused without bringing the entire Timeline
panel as a dependency. Also, made all component widgets of the layer viewer
to be web components.
==========

[commit-bot: I haz the power, 2016-09-23 03:21:46]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-09-23 03:25:40]

Description was changed from

==========
DevTools: extract a component for layer viewer

This lets the layer view to be reused without bringing the entire Timeline
panel as a dependency. Also, made all component widgets of the layer viewer
to be web components.
==========

to

==========
DevTools: extract a component for layer viewer

This lets the layer view to be reused without bringing the entire Timeline
panel as a dependency. Also, made all component widgets of the layer viewer
to be web components.

Committed: https://crrev.com/cc74cc44621d6771dc6fc15de0ecca1752a1b222
Cr-Commit-Position: refs/heads/master@{#420565}
==========

[commit-bot: I haz the power, 2016-09-23 03:25:41]

Patchset 3 (id:??) landed as
https://crrev.com/cc74cc44621d6771dc6fc15de0ecca1752a1b222
Cr-Commit-Position: refs/heads/master@{#420565}