Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Unified Diff: third_party/WebKit/Source/devtools/front_end/layer_viewer/PaintProfilerView.js

Issue 2358253002: DevTools: extract a component for layer viewer (Closed)
Patch Set: renamed the banner Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/layer_viewer/PaintProfilerView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/PaintProfilerView.js b/third_party/WebKit/Source/devtools/front_end/layer_viewer/PaintProfilerView.js
similarity index 97%
rename from third_party/WebKit/Source/devtools/front_end/timeline/PaintProfilerView.js
rename to third_party/WebKit/Source/devtools/front_end/layer_viewer/PaintProfilerView.js
index abc7606d22cde188c17915551eab6f5fddf2149a..2cf71a0bf95b9678de4891bd0cd5e804cc30e7f2 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/PaintProfilerView.js
+++ b/third_party/WebKit/Source/devtools/front_end/layer_viewer/PaintProfilerView.js
@@ -35,14 +35,15 @@
*/
WebInspector.PaintProfilerView = function(showImageCallback)
{
- WebInspector.HBox.call(this);
- this.element.classList.add("paint-profiler-overview", "hbox");
- this._canvasContainer = this.element.createChild("div", "paint-profiler-canvas-container");
- this._progressBanner = this.element.createChild("div", "banner hidden");
+ WebInspector.HBox.call(this, true);
+ this.registerRequiredCSS("layer_viewer/paintProfiler.css");
+ this.contentElement.classList.add("paint-profiler-overview");
+ this._canvasContainer = this.contentElement.createChild("div", "paint-profiler-canvas-container");
+ this._progressBanner = this.contentElement.createChild("div", "full-widget-dimmed-banner hidden");
this._progressBanner.textContent = WebInspector.UIString("Profiling\u2026");
this._pieChart = new WebInspector.PieChart(55, this._formatPieChartTime.bind(this), true);
this._pieChart.element.classList.add("paint-profiler-pie-chart");
- this.element.appendChild(this._pieChart.element);
+ this.contentElement.appendChild(this._pieChart.element);
this._showImageCallback = showImageCallback;
@@ -259,7 +260,7 @@ WebInspector.PaintProfilerCommandLogView = function()
{
WebInspector.VBox.call(this);
this.setMinimumSize(100, 25);
- this.element.classList.add("profiler-log-view");
+ this.element.classList.add("overflow-auto");
this._treeOutline = new TreeOutlineInShadow();
this.element.appendChild(this._treeOutline.element);

Powered by Google App Engine
This is Rietveld 408576698