Move OneWriterSeqLock and SharedMemorySeqLockBuffer from content/ to device/base/synchronization

Move OneWriterSeqLock and SharedMemorySeqLockBuffer from content/ to device/base/synchronization

The reason to move it to device/base/synchronization is that it is going to be used both for content/ Device Orientation and Gamepad and for device/ Generic Sensors.

Committed: https://crrev.com/b39a3082846d5877a15e8b7e18d66cb142abe8af
Committed: https://crrev.com/fca936a908d85b8fba37636d38662676d96fd5b0
Cr-Original-Commit-Position: refs/heads/master@{#422115}
Cr-Commit-Position: refs/heads/master@{#422203}

[darktears, 2016-09-22 22:26:05]

The CQ bit was checked by alexis.menard@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 22:26:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 23:30:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 23:30:48]

Dry run: This issue passed the CQ dry run.

[darktears, 2016-09-23 13:05:16]

alexis.menard@intel.com changed reviewers:
+ jam@chromium.org, timvolodine@chromium.org

[darktears, 2016-09-23 13:05:16]

@tim please take a look. I just moved the files, no functional changes. I didn't
move shared_memory_seqlock_reader because it's not required but as they kind of
belong together I can move the files as well.

[jam, 2016-09-23 16:23:45]

On 2016/09/23 13:05:16, darktears wrote:
> @tim please take a look. I just moved the files, no functional changes. I
didn't
> move shared_memory_seqlock_reader because it's not required but as they kind
of
> belong together I can move the files as well.

please add a base/owner
rubberstamp lgtm for content/ if they're fine.

[timvolodine, 2016-09-23 17:34:28]

+1 for base owner

lgtm % comments

Could you please update the description with rationale for moving it to base/?
e.g. mention that the seqlock is used in Device Orientation, Gamepad and Generic
sensors APIs.

https://codereview.chromium.org/2358123005/diff/1/base/synchronization/one_wr...
File base/synchronization/one_writer_seqlock.cc (right):

https://codereview.chromium.org/2358123005/diff/1/base/synchronization/one_wr...
base/synchronization/one_writer_seqlock.cc:1: // Copyright 2016 The Chromium
Authors. All rights reserved.
pls keep the original creation date (also as in .h file)

https://codereview.chromium.org/2358123005/diff/1/base/synchronization/shared...
File base/synchronization/shared_memory_seqlock_buffer.h (right):

https://codereview.chromium.org/2358123005/diff/1/base/synchronization/shared...
base/synchronization/shared_memory_seqlock_buffer.h:22: class
SharedMemorySeqLockBuffer {
should this actually be in base/? i.e. is it required by the generic sensors?
(otherwise can leave in content/common)

https://codereview.chromium.org/2358123005/diff/1/content/renderer/shared_mem...
File content/renderer/shared_memory_seqlock_reader.h (right):

https://codereview.chromium.org/2358123005/diff/1/content/renderer/shared_mem...
content/renderer/shared_memory_seqlock_reader.h:60: shared_memory_handle,
is this the correct indentation? I thought it should be +4sp

[darktears, 2016-09-23 17:53:01]

On 2016/09/23 17:34:28, timvolodine wrote:
> +1 for base owner
> 
> lgtm % comments
> 
> Could you please update the description with rationale for moving it to base/?
> e.g. mention that the seqlock is used in Device Orientation, Gamepad and
Generic
> sensors APIs.
> 
>
https://codereview.chromium.org/2358123005/diff/1/base/synchronization/one_wr...
> File base/synchronization/one_writer_seqlock.cc (right):
> 
>
https://codereview.chromium.org/2358123005/diff/1/base/synchronization/one_wr...
> base/synchronization/one_writer_seqlock.cc:1: // Copyright 2016 The Chromium
> Authors. All rights reserved.
> pls keep the original creation date (also as in .h file)

Ok.

> 
>
https://codereview.chromium.org/2358123005/diff/1/base/synchronization/shared...
> File base/synchronization/shared_memory_seqlock_buffer.h (right):
> 
>
https://codereview.chromium.org/2358123005/diff/1/base/synchronization/shared...
> base/synchronization/shared_memory_seqlock_buffer.h:22: class
> SharedMemorySeqLockBuffer {
> should this actually be in base/? i.e. is it required by the generic sensors?
> (otherwise can leave in content/common)

That's what we use actually.

> 
>
https://codereview.chromium.org/2358123005/diff/1/content/renderer/shared_mem...
> File content/renderer/shared_memory_seqlock_reader.h (right):
> 
>
https://codereview.chromium.org/2358123005/diff/1/content/renderer/shared_mem...
> content/renderer/shared_memory_seqlock_reader.h:60: shared_memory_handle,
> is this the correct indentation? I thought it should be +4sp

git cl format did it for me.

[darktears, 2016-09-23 17:55:14]

Description was changed from

==========
Move OneWriterSeqLock and SharedMemorySeqLockBuffer from content/ to base/

They turn out to be useful in device/ for the implementation of
the generic sensor (multiple read, single writer use case).

BUG=
==========

to

==========
Move OneWriterSeqLock and SharedMemorySeqLockBuffer from content/ to base/
    
The reason to move it to base/ is that it is going to be used both
for content/ Device Orientation and Gamepad and for device/ Generic
Sensors.

BUG=
==========

[darktears, 2016-09-23 17:55:14]

alexis.menard@intel.com changed reviewers:
+ mark@chromium.org, thakis@chromium.org

[darktears, 2016-09-23 19:54:38]

alexis.menard@intel.com changed reviewers:
+ danakj@chromium.org, dcheng@chromium.org, thestig@chromium.org

[timvolodine, 2016-09-26 15:07:41]

+cc: blundell@ FYI (who is also looking at device related refactorings)

[blundell, 2016-09-26 15:09:28]

On 2016/09/26 15:07:41, timvolodine wrote:
> +cc: blundell@ FYI (who is also looking at device related refactorings)

I had looked a little bit at these files. Will they be used anywhere *other*
than in //device once all the decoupling is completed? If not, maybe they should
just go to //device? The bar for going in //base is high.

[timvolodine, 2016-09-26 15:20:41]

On 2016/09/26 15:09:28, blundell wrote:
> On 2016/09/26 15:07:41, timvolodine wrote:
> > +cc: blundell@ FYI (who is also looking at device related refactorings)
> 
> I had looked a little bit at these files. Will they be used anywhere *other*
> than in //device once all the decoupling is completed? If not, maybe they
should
> just go to //device? The bar for going in //base is high.

AFAIK they are used only by the apis listed in the description, so device/ would
probably also work... the seqlock code seemed like basic enough to warrant a
base/ placement with the other synchronization primitives though..

[blundell, 2016-09-27 10:54:51]

blundell@chromium.org changed reviewers:
+ blundell@chromium.org

[blundell, 2016-09-27 10:55:23]

We can leave it up to a //base owner.

[darktears, 2016-09-27 22:26:36]

alexis.menard@intel.com changed reviewers:
+ brettw@chromium.org

[Lei Zhang, 2016-09-27 22:29:07]

If it's only going to be used in content/ and device/ and device/OWNERS are
willing to accept it, move it to device/ ?

[Reilly Grant (use Gerrit), 2016-09-28 02:12:13]

On 2016/09/27 at 22:29:07, thestig wrote:
> If it's only going to be used in content/ and device/ and device/OWNERS are
willing to accept it, move it to device/ ?

I'm willing to accept it into //device/core. It should probably be renamed
//device/base to match the naming convention used in other directories such as
//media/base.

[darktears, 2016-09-28 14:56:33]

On 2016/09/28 02:12:13, Reilly Grant wrote:
> On 2016/09/27 at 22:29:07, thestig wrote:
> > If it's only going to be used in content/ and device/ and device/OWNERS are
> willing to accept it, move it to device/ ?
> 
> I'm willing to accept it into //device/core. It should probably be renamed
> //device/base to match the naming convention used in other directories such as
> //media/base.

Ok. I'll make the patch to move it to device/core. I will be doing a rename from
core/ to base/ in a later patch.

[darktears, 2016-09-28 15:57:51]

The CQ bit was checked by alexis.menard@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 15:58:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[darktears, 2016-09-28 15:59:19]

Description was changed from

==========
Move OneWriterSeqLock and SharedMemorySeqLockBuffer from content/ to base/
    
The reason to move it to base/ is that it is going to be used both
for content/ Device Orientation and Gamepad and for device/ Generic
Sensors.

BUG=
==========

to

==========
Move OneWriterSeqLock and SharedMemorySeqLockBuffer from content/ to device/core
    
The reason to move it to device/core is that it is going to be used both
for content/ Device Orientation and Gamepad and for device/ Generic Sensors.
    
BUG=
==========

[darktears, 2016-09-28 15:59:19]

alexis.menard@intel.com changed reviewers:
- brettw@chromium.org, danakj@chromium.org, dcheng@chromium.org,
mark@chromium.org, thakis@chromium.org, thestig@chromium.org

[darktears, 2016-09-28 16:00:01]

alexis.menard@intel.com changed reviewers:
+ reillyg@chromium.org

[commit-bot: I haz the power, 2016-09-28 16:01:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 16:01:49]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[darktears, 2016-09-28 16:36:30]

The CQ bit was checked by alexis.menard@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 16:37:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[darktears, 2016-09-28 17:35:06]

On 2016/09/28 14:56:33, darktears wrote:
> On 2016/09/28 02:12:13, Reilly Grant wrote:
> > On 2016/09/27 at 22:29:07, thestig wrote:
> > > If it's only going to be used in content/ and device/ and device/OWNERS
are
> > willing to accept it, move it to device/ ?
> > 
> > I'm willing to accept it into //device/core. It should probably be renamed
> > //device/base to match the naming convention used in other directories such
as
> > //media/base.
> 
> Ok. I'll make the patch to move it to device/core. I will be doing a rename
from
> core/ to base/ in a later patch.

@reillyg @timvolodine : ok ready for review.

[commit-bot: I haz the power, 2016-09-28 18:09:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 18:09:59]

Dry run: This issue passed the CQ dry run.

[timvolodine, 2016-09-28 19:23:38]

https://codereview.chromium.org/2358123005/diff/80001/content/common/BUILD.gn
File content/common/BUILD.gn (right):

https://codereview.chromium.org/2358123005/diff/80001/content/common/BUILD.gn...
content/common/BUILD.gn:368: "//device/core",
can we have a more specific dependency? i.e. //device/core contains some other
files that do not seem to be used by either content/common or content/renderer.
maybe have a dedicated directory in device/ for this?

[darktears, 2016-09-28 19:53:57]

On 2016/09/28 19:23:38, timvolodine wrote:
> https://codereview.chromium.org/2358123005/diff/80001/content/common/BUILD.gn
> File content/common/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2358123005/diff/80001/content/common/BUILD.gn...
> content/common/BUILD.gn:368: "//device/core",
> can we have a more specific dependency? i.e. //device/core contains some other
> files that do not seem to be used by either content/common or
content/renderer.
> maybe have a dedicated directory in device/ for this?

core/synchronization?

[Reilly Grant (use Gerrit), 2016-09-29 04:41:32]

On 2016/09/28 at 19:53:57, alexis.menard wrote:
> On 2016/09/28 19:23:38, timvolodine wrote:
> >
https://codereview.chromium.org/2358123005/diff/80001/content/common/BUILD.gn
> > File content/common/BUILD.gn (right):
> > 
> >
https://codereview.chromium.org/2358123005/diff/80001/content/common/BUILD.gn...
> > content/common/BUILD.gn:368: "//device/core",
> > can we have a more specific dependency? i.e. //device/core contains some
other
> > files that do not seem to be used by either content/common or
content/renderer.
> > maybe have a dedicated directory in device/ for this?
> 
> core/synchronization?

Sure, use a source_set() so that you don't need an export header. //device/core
needs to be a component because it contains global state.

[timvolodine, 2016-09-29 12:28:41]

On 2016/09/29 04:41:32, Reilly Grant wrote:
> On 2016/09/28 at 19:53:57, alexis.menard wrote:
> > On 2016/09/28 19:23:38, timvolodine wrote:
> > >
> https://codereview.chromium.org/2358123005/diff/80001/content/common/BUILD.gn
> > > File content/common/BUILD.gn (right):
> > > 
> > >
>
https://codereview.chromium.org/2358123005/diff/80001/content/common/BUILD.gn...
> > > content/common/BUILD.gn:368: "//device/core",
> > > can we have a more specific dependency? i.e. //device/core contains some
> other
> > > files that do not seem to be used by either content/common or
> content/renderer.
> > > maybe have a dedicated directory in device/ for this?
> > 
> > core/synchronization?
> 
> Sure, use a source_set() so that you don't need an export header.
//device/core
> needs to be a component because it contains global state.

or maybe just device/base, or device/base/synchronization?
not sure about device/core, seems like a separate 'component' anyway and looks
more 'hardware' related.. (correct me if I am wrong)

[Reilly Grant (use Gerrit), 2016-09-29 12:30:27]

On 2016/09/29 at 12:28:41, timvolodine wrote:
> On 2016/09/29 04:41:32, Reilly Grant wrote:
> > On 2016/09/28 at 19:53:57, alexis.menard wrote:
> > > On 2016/09/28 19:23:38, timvolodine wrote:
> > > >
> >
https://codereview.chromium.org/2358123005/diff/80001/content/common/BUILD.gn
> > > > File content/common/BUILD.gn (right):
> > > > 
> > > >
> >
https://codereview.chromium.org/2358123005/diff/80001/content/common/BUILD.gn...
> > > > content/common/BUILD.gn:368: "//device/core",
> > > > can we have a more specific dependency? i.e. //device/core contains some
> > other
> > > > files that do not seem to be used by either content/common or
> > content/renderer.
> > > > maybe have a dedicated directory in device/ for this?
> > > 
> > > core/synchronization?
> > 
> > Sure, use a source_set() so that you don't need an export header.
//device/core
> > needs to be a component because it contains global state.
> 
> or maybe just device/base, or device/base/synchronization?
> not sure about device/core, seems like a separate 'component' anyway and looks
more 'hardware' related.. (correct me if I am wrong)

//device is all about hardware access.

[darktears, 2016-09-29 14:08:34]

On 2016/09/29 12:30:27, Reilly Grant wrote:
> On 2016/09/29 at 12:28:41, timvolodine wrote:
> > On 2016/09/29 04:41:32, Reilly Grant wrote:
> > > On 2016/09/28 at 19:53:57, alexis.menard wrote:
> > > > On 2016/09/28 19:23:38, timvolodine wrote:
> > > > >
> > >
> https://codereview.chromium.org/2358123005/diff/80001/content/common/BUILD.gn
> > > > > File content/common/BUILD.gn (right):
> > > > > 
> > > > >
> > >
>
https://codereview.chromium.org/2358123005/diff/80001/content/common/BUILD.gn...
> > > > > content/common/BUILD.gn:368: "//device/core",
> > > > > can we have a more specific dependency? i.e. //device/core contains
some
> > > other
> > > > > files that do not seem to be used by either content/common or
> > > content/renderer.
> > > > > maybe have a dedicated directory in device/ for this?
> > > > 
> > > > core/synchronization?
> > > 
> > > Sure, use a source_set() so that you don't need an export header.
> //device/core
> > > needs to be a component because it contains global state.
> > 
> > or maybe just device/base, or device/base/synchronization?
> > not sure about device/core, seems like a separate 'component' anyway and
looks
> more 'hardware' related.. (correct me if I am wrong)
> 
> //device is all about hardware access.

I can put in device/core/synchronization then in a later patch I will rename
device/core to device/base so at the end those files are going to be in
device/base/synchronization

Is that ok?

[timvolodine, 2016-09-29 15:12:34]

On 2016/09/29 14:08:34, darktears wrote:
> On 2016/09/29 12:30:27, Reilly Grant wrote:
> > On 2016/09/29 at 12:28:41, timvolodine wrote:
> > > On 2016/09/29 04:41:32, Reilly Grant wrote:
> > > > On 2016/09/28 at 19:53:57, alexis.menard wrote:
> > > > > On 2016/09/28 19:23:38, timvolodine wrote:
> > > > > >
> > > >
> >
https://codereview.chromium.org/2358123005/diff/80001/content/common/BUILD.gn
> > > > > > File content/common/BUILD.gn (right):
> > > > > > 
> > > > > >
> > > >
> >
>
https://codereview.chromium.org/2358123005/diff/80001/content/common/BUILD.gn...
> > > > > > content/common/BUILD.gn:368: "//device/core",
> > > > > > can we have a more specific dependency? i.e. //device/core contains
> some
> > > > other
> > > > > > files that do not seem to be used by either content/common or
> > > > content/renderer.
> > > > > > maybe have a dedicated directory in device/ for this?
> > > > > 
> > > > > core/synchronization?
> > > > 
> > > > Sure, use a source_set() so that you don't need an export header.
> > //device/core
> > > > needs to be a component because it contains global state.
> > > 
> > > or maybe just device/base, or device/base/synchronization?
> > > not sure about device/core, seems like a separate 'component' anyway and
> looks
> > more 'hardware' related.. (correct me if I am wrong)
> > 
> > //device is all about hardware access.
> 
> I can put in device/core/synchronization then in a later patch I will rename
> device/core to device/base so at the end those files are going to be in
> device/base/synchronization
> 
> Is that ok?

you could put it in base/synchronization first since it will be a source_set and
then decide later what to do with the core component

[darktears, 2016-09-29 16:51:29]

Description was changed from

==========
Move OneWriterSeqLock and SharedMemorySeqLockBuffer from content/ to device/core
    
The reason to move it to device/core is that it is going to be used both
for content/ Device Orientation and Gamepad and for device/ Generic Sensors.
    
BUG=
==========

to

==========
Move OneWriterSeqLock and SharedMemorySeqLockBuffer from content/ to
device/base/synchronization
    
The reason to move it to device/base/synchronization is that it is going to be
used both for content/ Device Orientation and Gamepad and for device/ Generic
Sensors.
==========

[darktears, 2016-09-29 16:51:52]

The CQ bit was checked by alexis.menard@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 16:52:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 17:08:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 17:08:17]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[darktears, 2016-09-29 17:29:41]

The CQ bit was checked by alexis.menard@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 17:30:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[darktears, 2016-09-29 18:17:45]

On 2016/09/29 15:12:34, timvolodine wrote:
> On 2016/09/29 14:08:34, darktears wrote:
> > On 2016/09/29 12:30:27, Reilly Grant wrote:
> > > On 2016/09/29 at 12:28:41, timvolodine wrote:
> > > > On 2016/09/29 04:41:32, Reilly Grant wrote:
> > > > > On 2016/09/28 at 19:53:57, alexis.menard wrote:
> > > > > > On 2016/09/28 19:23:38, timvolodine wrote:
> > > > > > >
> > > > >
> > >
> https://codereview.chromium.org/2358123005/diff/80001/content/common/BUILD.gn
> > > > > > > File content/common/BUILD.gn (right):
> > > > > > > 
> > > > > > >
> > > > >
> > >
> >
>
https://codereview.chromium.org/2358123005/diff/80001/content/common/BUILD.gn...
> > > > > > > content/common/BUILD.gn:368: "//device/core",
> > > > > > > can we have a more specific dependency? i.e. //device/core
contains
> > some
> > > > > other
> > > > > > > files that do not seem to be used by either content/common or
> > > > > content/renderer.
> > > > > > > maybe have a dedicated directory in device/ for this?
> > > > > > 
> > > > > > core/synchronization?
> > > > > 
> > > > > Sure, use a source_set() so that you don't need an export header.
> > > //device/core
> > > > > needs to be a component because it contains global state.
> > > > 
> > > > or maybe just device/base, or device/base/synchronization?
> > > > not sure about device/core, seems like a separate 'component' anyway and
> > looks
> > > more 'hardware' related.. (correct me if I am wrong)
> > > 
> > > //device is all about hardware access.
> > 
> > I can put in device/core/synchronization then in a later patch I will rename
> > device/core to device/base so at the end those files are going to be in
> > device/base/synchronization
> > 
> > Is that ok?
> 
> you could put it in base/synchronization first since it will be a source_set
and
> then decide later what to do with the core component

Alright hopefully this time is good :). Please review.

[commit-bot: I haz the power, 2016-09-29 18:59:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 19:00:00]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Reilly Grant (use Gerrit), 2016-09-30 02:05:10]

lgtm with a nit

https://codereview.chromium.org/2358123005/diff/120001/device/base/synchroniz...
File device/base/synchronization/one_writer_seqlock_unittest.cc (right):

https://codereview.chromium.org/2358123005/diff/120001/device/base/synchroniz...
device/base/synchronization/one_writer_seqlock_unittest.cc:28: void
Init(device::OneWriterSeqLock* seqlock,
This is in the device namespace so device:: isn't needed here, and below.

[darktears, 2016-09-30 03:23:11]

The CQ bit was checked by alexis.menard@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 03:23:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[darktears, 2016-09-30 03:28:25]

The CQ bit was checked by alexis.menard@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 03:28:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[darktears, 2016-09-30 03:28:46]

On 2016/09/30 02:05:10, Reilly Grant wrote:
> lgtm with a nit
> 
>
https://codereview.chromium.org/2358123005/diff/120001/device/base/synchroniz...
> File device/base/synchronization/one_writer_seqlock_unittest.cc (right):
> 
>
https://codereview.chromium.org/2358123005/diff/120001/device/base/synchroniz...
> device/base/synchronization/one_writer_seqlock_unittest.cc:28: void
> Init(device::OneWriterSeqLock* seqlock,
> This is in the device namespace so device:: isn't needed here, and below.

@volodine : if that's ok with you, feel free to CQ it. Thanks.

[commit-bot: I haz the power, 2016-09-30 04:26:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 04:26:58]

Dry run: This issue passed the CQ dry run.

[darktears, 2016-09-30 15:08:24]

The CQ bit was checked by alexis.menard@intel.com

[darktears, 2016-09-30 15:08:24]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org,
timvolodine@chromium.org, reillyg@chromium.org
Link to the patchset: https://codereview.chromium.org/2358123005/#ps160001
(title: "Fix nits")

[commit-bot: I haz the power, 2016-09-30 15:08:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 15:14:58]

Description was changed from

==========
Move OneWriterSeqLock and SharedMemorySeqLockBuffer from content/ to
device/base/synchronization
    
The reason to move it to device/base/synchronization is that it is going to be
used both for content/ Device Orientation and Gamepad and for device/ Generic
Sensors.
==========

to

==========
Move OneWriterSeqLock and SharedMemorySeqLockBuffer from content/ to
device/base/synchronization
    
The reason to move it to device/base/synchronization is that it is going to be
used both for content/ Device Orientation and Gamepad and for device/ Generic
Sensors.
==========

[commit-bot: I haz the power, 2016-09-30 15:14:59]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-09-30 15:16:49]

Description was changed from

==========
Move OneWriterSeqLock and SharedMemorySeqLockBuffer from content/ to
device/base/synchronization
    
The reason to move it to device/base/synchronization is that it is going to be
used both for content/ Device Orientation and Gamepad and for device/ Generic
Sensors.
==========

to

==========
Move OneWriterSeqLock and SharedMemorySeqLockBuffer from content/ to
device/base/synchronization

The reason to move it to device/base/synchronization is that it is going to be
used both for content/ Device Orientation and Gamepad and for device/ Generic
Sensors.

Committed: https://crrev.com/b39a3082846d5877a15e8b7e18d66cb142abe8af
Cr-Commit-Position: refs/heads/master@{#422115}
==========

[commit-bot: I haz the power, 2016-09-30 15:16:50]

Patchset 9 (id:??) landed as
https://crrev.com/b39a3082846d5877a15e8b7e18d66cb142abe8af
Cr-Commit-Position: refs/heads/master@{#422115}

[timvolodine, 2016-09-30 17:22:05]

thanks! lgtm

https://codereview.chromium.org/2358123005/diff/160001/device/base/synchroniz...
File device/base/synchronization/BUILD.gn (right):

https://codereview.chromium.org/2358123005/diff/160001/device/base/synchroniz...
device/base/synchronization/BUILD.gn:5: import("//build/config/features.gni")
nit: not needed?

https://codereview.chromium.org/2358123005/diff/160001/device/base/synchroniz...
File device/base/synchronization/shared_memory_seqlock_buffer.h (right):

https://codereview.chromium.org/2358123005/diff/160001/device/base/synchroniz...
device/base/synchronization/shared_memory_seqlock_buffer.h:30: #endif  //
DEVICE_CORE_SHARED_MEMORY_SEQLOCK_BUFFER_H_
-> DEVICE_BASE_SYNCHRONIZATION_SHARED_MEMORY_SEQLOCK_BUFFER_H_

[darktears, 2016-09-30 19:28:18]

Description was changed from

==========
Move OneWriterSeqLock and SharedMemorySeqLockBuffer from content/ to
device/base/synchronization

The reason to move it to device/base/synchronization is that it is going to be
used both for content/ Device Orientation and Gamepad and for device/ Generic
Sensors.

Committed: https://crrev.com/b39a3082846d5877a15e8b7e18d66cb142abe8af
Cr-Commit-Position: refs/heads/master@{#422115}
==========

to

==========
Move OneWriterSeqLock and SharedMemorySeqLockBuffer from content/ to
device/base/synchronization

The reason to move it to device/base/synchronization is that it is going to be
used both for content/ Device Orientation and Gamepad and for device/ Generic
Sensors.

Committed: https://crrev.com/b39a3082846d5877a15e8b7e18d66cb142abe8af
Cr-Commit-Position: refs/heads/master@{#422115}
==========

[darktears, 2016-09-30 19:28:23]

The CQ bit was checked by alexis.menard@intel.com

[darktears, 2016-09-30 19:28:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
reillyg@chromium.org, jam@chromium.org, timvolodine@chromium.org
Link to the patchset: https://codereview.chromium.org/2358123005/#ps170001
(title: "Tim fixes")

[commit-bot: I haz the power, 2016-09-30 19:29:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 20:24:11]

Description was changed from

==========
Move OneWriterSeqLock and SharedMemorySeqLockBuffer from content/ to
device/base/synchronization

The reason to move it to device/base/synchronization is that it is going to be
used both for content/ Device Orientation and Gamepad and for device/ Generic
Sensors.

Committed: https://crrev.com/b39a3082846d5877a15e8b7e18d66cb142abe8af
Cr-Commit-Position: refs/heads/master@{#422115}
==========

to

==========
Move OneWriterSeqLock and SharedMemorySeqLockBuffer from content/ to
device/base/synchronization

The reason to move it to device/base/synchronization is that it is going to be
used both for content/ Device Orientation and Gamepad and for device/ Generic
Sensors.

Committed: https://crrev.com/b39a3082846d5877a15e8b7e18d66cb142abe8af
Cr-Commit-Position: refs/heads/master@{#422115}
==========

[commit-bot: I haz the power, 2016-09-30 20:24:13]

Committed patchset #10 (id:170001)

[commit-bot: I haz the power, 2016-09-30 20:26:08]

Description was changed from

==========
Move OneWriterSeqLock and SharedMemorySeqLockBuffer from content/ to
device/base/synchronization

The reason to move it to device/base/synchronization is that it is going to be
used both for content/ Device Orientation and Gamepad and for device/ Generic
Sensors.

Committed: https://crrev.com/b39a3082846d5877a15e8b7e18d66cb142abe8af
Cr-Commit-Position: refs/heads/master@{#422115}
==========

to

==========
Move OneWriterSeqLock and SharedMemorySeqLockBuffer from content/ to
device/base/synchronization

The reason to move it to device/base/synchronization is that it is going to be
used both for content/ Device Orientation and Gamepad and for device/ Generic
Sensors.

Committed: https://crrev.com/b39a3082846d5877a15e8b7e18d66cb142abe8af
Committed: https://crrev.com/fca936a908d85b8fba37636d38662676d96fd5b0
Cr-Original-Commit-Position: refs/heads/master@{#422115}
Cr-Commit-Position: refs/heads/master@{#422203}
==========

[commit-bot: I haz the power, 2016-09-30 20:26:10]

Patchset 10 (id:??) landed as
https://crrev.com/fca936a908d85b8fba37636d38662676d96fd5b0
Cr-Commit-Position: refs/heads/master@{#422203}