Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2358123004: Revert of Some Vulkan memory fixes and cleanup (Closed)

Created:
4 years, 3 months ago by jvanverth1
Modified:
4 years, 3 months ago
Reviewers:
Brian Osman, egdaniel
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Some Vulkan memory fixes and cleanup (patchset #2 id:20001 of https://codereview.chromium.org/2356343003/ ) Reason for revert: fHeapIndex is not used in release, need to hide behind SK_DEBUG. Failing on Perf-Android-Clang-NVIDIA_Shield-GPU-TegraX1-arm64-Release-GN_Android_Vulkan. Original issue's description: > Some Vulkan memory fixes and cleanup > > * Switch back to not setting transfer_dst on all buffers > * Add some missing unit tests > * Add tracking of heap usage for debugging purposes > * Fall back to non-device-local memory if device-local allocation fails > > BUG=skia:5031 > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2356343003 > > Committed: https://skia.googlesource.com/skia/+/c5850e9fdb62cc4ae5ed2b6af51aea92cac07455 TBR=egdaniel@google.com,brianosman@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:5031 Committed: https://skia.googlesource.com/skia/+/ae6e4869c94596eb3bf5069888b32ab06199aec0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -122 lines) Patch
M src/gpu/vk/GrVkBuffer.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M src/gpu/vk/GrVkMemory.h View 3 chunks +9 lines, -13 lines 0 comments Download
M src/gpu/vk/GrVkMemory.cpp View 15 chunks +21 lines, -61 lines 0 comments Download
M tests/VkHeapTests.cpp View 4 chunks +19 lines, -45 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jvanverth1
Created Revert of Some Vulkan memory fixes and cleanup
4 years, 3 months ago (2016-09-22 20:45:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2358123004/1
4 years, 3 months ago (2016-09-22 20:45:19 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 20:45:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ae6e4869c94596eb3bf5069888b32ab06199aec0

Powered by Google App Engine
This is Rietveld 408576698