Reland 220012: Move the functions of filebrowserPrivateApi from the file_manager namespace to the e…

chrome/browser/chromeos/extensions/file_manager/private_api_dialog.h

Index: chrome/browser/chromeos/extensions/file_manager/private_api_dialog.h
diff --git a/chrome/browser/chromeos/extensions/file_manager/private_api_dialog.h b/chrome/browser/chromeos/extensions/file_manager/private_api_dialog.h
index ba8cdf1467fe82f196244c0177b1797d635d90d1..fcc939b21fca7e27eba30f2ffc58dad907ae7586 100644
--- a/chrome/browser/chromeos/extensions/file_manager/private_api_dialog.h
+++ b/chrome/browser/chromeos/extensions/file_manager/private_api_dialog.h
@@ -15,10 +15,11 @@ namespace ui {
 struct SelectedFileInfo;
 }
 
-namespace file_manager {
+namespace extensions {
 
 // Cancel file selection Dialog.  Closes the dialog window.
-class CancelFileDialogFunction : public LoggedAsyncExtensionFunction {
+class CancelFileDialogFunction
+    : public file_manager::LoggedAsyncExtensionFunction {

[satorux1, 2013/08/29 03:34:42]

why not moving LoggedAsyncExtensionFunction to extensions?

[hirono, 2013/08/29 03:41:59]

Because the extensions namespace is referred by many other API implementations.
LoggedAsyncExtensionFunction is used by only the file manager private API and I
think we should not add it to the common space.

[satorux1, 2013/08/29 03:50:00]

I guess we don't have to worry about the namespace pollution for this.  Having
the extension binding stuff in the same 'extensions' namespace would be
desirable. We can easily move this to  extensions::file_manager if it becomes a
problem.

[hirono, 2013/08/29 06:24:32]

Done.

  public:
   DECLARE_EXTENSION_FUNCTION("fileBrowserPrivate.cancelDialog",
                              FILEBROWSERPRIVATE_CANCELDIALOG)
@@ -32,7 +33,7 @@ class CancelFileDialogFunction : public LoggedAsyncExtensionFunction {
   virtual bool RunImpl() OVERRIDE;
 };
 
-class SelectFileFunction : public LoggedAsyncExtensionFunction {
+class SelectFileFunction : public file_manager::LoggedAsyncExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("fileBrowserPrivate.selectFile",
                              FILEBROWSERPRIVATE_SELECTFILE)
@@ -52,7 +53,7 @@ class SelectFileFunction : public LoggedAsyncExtensionFunction {
 };
 
 // Select multiple files.  Closes the dialog window.
-class SelectFilesFunction : public LoggedAsyncExtensionFunction {
+class SelectFilesFunction : public file_manager::LoggedAsyncExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("fileBrowserPrivate.selectFiles",
                              FILEBROWSERPRIVATE_SELECTFILES)
@@ -71,6 +72,6 @@ class SelectFilesFunction : public LoggedAsyncExtensionFunction {
       const std::vector<ui::SelectedFileInfo>& files);
 };
 
-}  // namespace file_manager
+}  // namespace extensions
 
 #endif  // CHROME_BROWSER_CHROMEOS_EXTENSIONS_FILE_MANAGER_PRIVATE_API_DIALOG_H_