Reland 220012: Move the functions of filebrowserPrivateApi from the file_manager namespace to the e…

chrome/browser/chromeos/extensions/file_manager/private_api_dialog.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file provides API functions for the file manager to act as the file
 // dialog for opening and saving files.
 
 #ifndef CHROME_BROWSER_CHROMEOS_EXTENSIONS_FILE_MANAGER_PRIVATE_API_DIALOG_H_
 #define CHROME_BROWSER_CHROMEOS_EXTENSIONS_FILE_MANAGER_PRIVATE_API_DIALOG_H_
 
 #include <vector>
 #include "chrome/browser/chromeos/extensions/file_manager/private_api_base.h"
 
 namespace ui {
 struct SelectedFileInfo;
 }
 
-namespace file_manager {
+namespace extensions {
 
 // Cancel file selection Dialog.  Closes the dialog window.
-class CancelFileDialogFunction : public LoggedAsyncExtensionFunction {
+class CancelFileDialogFunction
+    : public file_manager::LoggedAsyncExtensionFunction {

[satorux1, 2013/08/29 03:34:42]

why not moving LoggedAsyncExtensionFunction to extensions?

[hirono, 2013/08/29 03:41:59]

Because the extensions namespace is referred by many other API implementations.
LoggedAsyncExtensionFunction is used by only the file manager private API and I
think we should not add it to the common space.

[satorux1, 2013/08/29 03:50:00]

I guess we don't have to worry about the namespace pollution for this.  Having
the extension binding stuff in the same 'extensions' namespace would be
desirable. We can easily move this to  extensions::file_manager if it becomes a
problem.

[hirono, 2013/08/29 06:24:32]

Done.

  public:
   DECLARE_EXTENSION_FUNCTION("fileBrowserPrivate.cancelDialog",
                              FILEBROWSERPRIVATE_CANCELDIALOG)
 
   CancelFileDialogFunction();
 
  protected:
   virtual ~CancelFileDialogFunction();
 
   // AsyncExtensionFunction overrides.
   virtual bool RunImpl() OVERRIDE;
 };
 
-class SelectFileFunction : public LoggedAsyncExtensionFunction {
+class SelectFileFunction : public file_manager::LoggedAsyncExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("fileBrowserPrivate.selectFile",
                              FILEBROWSERPRIVATE_SELECTFILE)
 
   SelectFileFunction();
 
  protected:
   virtual ~SelectFileFunction();
 
   // AsyncExtensionFunction overrides.
   virtual bool RunImpl() OVERRIDE;
 
  private:
   // A callback method to handle the result of GetSelectedFileInfo.
   void GetSelectedFileInfoResponse(
       const std::vector<ui::SelectedFileInfo>& files);
 };
 
 // Select multiple files.  Closes the dialog window.
-class SelectFilesFunction : public LoggedAsyncExtensionFunction {
+class SelectFilesFunction : public file_manager::LoggedAsyncExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("fileBrowserPrivate.selectFiles",
                              FILEBROWSERPRIVATE_SELECTFILES)
 
   SelectFilesFunction();
 
  protected:
   virtual ~SelectFilesFunction();
 
   // AsyncExtensionFunction overrides.
   virtual bool RunImpl() OVERRIDE;
 
  private:
   // A callback method to handle the result of GetSelectedFileInfo.
   void GetSelectedFileInfoResponse(
       const std::vector<ui::SelectedFileInfo>& files);
 };
 
-}  // namespace file_manager
+}  // namespace extensions
 
 #endif  // CHROME_BROWSER_CHROMEOS_EXTENSIONS_FILE_MANAGER_PRIVATE_API_DIALOG_H_