Reland 220012: Move the functions of filebrowserPrivateApi from the file_manager namespace to the e…

Reland 220012: Move the functions of filebrowserPrivateApi from the file_manager namespace to the extensions namespace.

Previous version is reverted because of conflicting changes.

Previously reverted CL: crrev.com/23545015.

BUG=253358
TEST=file_manager_browsertests
R=hashimoto@chromium.org, satorux@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220489

[hirono, 2013-08-29 03:30:34]

Could you take a look to the reland CL?
The previous CL is reverted because of conflicting changes.
Thank you very much!

[satorux1, 2013-08-29 03:34:41]

https://codereview.chromium.org/23581006/diff/1/chrome/browser/chromeos/exten...
File chrome/browser/chromeos/extensions/file_manager/private_api_dialog.h
(right):

https://codereview.chromium.org/23581006/diff/1/chrome/browser/chromeos/exten...
chrome/browser/chromeos/extensions/file_manager/private_api_dialog.h:22: :
public file_manager::LoggedAsyncExtensionFunction {
why not moving LoggedAsyncExtensionFunction to extensions?

[hirono, 2013-08-29 03:41:59]

https://codereview.chromium.org/23581006/diff/1/chrome/browser/chromeos/exten...
File chrome/browser/chromeos/extensions/file_manager/private_api_dialog.h
(right):

https://codereview.chromium.org/23581006/diff/1/chrome/browser/chromeos/exten...
chrome/browser/chromeos/extensions/file_manager/private_api_dialog.h:22: :
public file_manager::LoggedAsyncExtensionFunction {
On 2013/08/29 03:34:42, satorux1 wrote:
> why not moving LoggedAsyncExtensionFunction to extensions?

Because the extensions namespace is referred by many other API implementations.
LoggedAsyncExtensionFunction is used by only the file manager private API and I
think we should not add it to the common space.

[satorux1, 2013-08-29 03:50:00]

https://codereview.chromium.org/23581006/diff/1/chrome/browser/chromeos/exten...
File chrome/browser/chromeos/extensions/file_manager/private_api_dialog.h
(right):

https://codereview.chromium.org/23581006/diff/1/chrome/browser/chromeos/exten...
chrome/browser/chromeos/extensions/file_manager/private_api_dialog.h:22: :
public file_manager::LoggedAsyncExtensionFunction {
On 2013/08/29 03:41:59, hirono wrote:
> On 2013/08/29 03:34:42, satorux1 wrote:
> > why not moving LoggedAsyncExtensionFunction to extensions?
> 
> Because the extensions namespace is referred by many other API
implementations.
> LoggedAsyncExtensionFunction is used by only the file manager private API and
I
> think we should not add it to the common space.

I guess we don't have to worry about the namespace pollution for this.  Having
the extension binding stuff in the same 'extensions' namespace would be
desirable. We can easily move this to  extensions::file_manager if it becomes a
problem.

[hirono, 2013-08-29 06:24:32]

So I move the LoggedAsyncExtensionFunction into extensions namespace.
Thank you!

https://codereview.chromium.org/23581006/diff/1/chrome/browser/chromeos/exten...
File chrome/browser/chromeos/extensions/file_manager/private_api_dialog.h
(right):

https://codereview.chromium.org/23581006/diff/1/chrome/browser/chromeos/exten...
chrome/browser/chromeos/extensions/file_manager/private_api_dialog.h:22: :
public file_manager::LoggedAsyncExtensionFunction {
On 2013/08/29 03:50:00, satorux1 wrote:
> On 2013/08/29 03:41:59, hirono wrote:
> > On 2013/08/29 03:34:42, satorux1 wrote:
> > > why not moving LoggedAsyncExtensionFunction to extensions?
> > 
> > Because the extensions namespace is referred by many other API
> implementations.
> > LoggedAsyncExtensionFunction is used by only the file manager private API
and
> I
> > think we should not add it to the common space.
> 
> I guess we don't have to worry about the namespace pollution for this.  Having
> the extension binding stuff in the same 'extensions' namespace would be
> desirable. We can easily move this to  extensions::file_manager if it becomes
a
> problem.

Done.

[satorux1, 2013-08-29 08:21:05]

LGTM. I'd suggest run "git cl try" and dcommit once try bots are green, rather
than going through CQ. Lots of changes are happening in this directory now. :P

[hashimoto, 2013-08-29 09:14:29]

lgtm

[hirono, 2013-08-30 02:43:24]

Committed patchset #6 manually as r220489 (presubmit successful).