mb: Add a recipe for the chromium.perf.fyi Win Clang Builder

mb: Add a recipe for the chromium.perf.fyi Win Clang Builder

BUG=649539
Committed: https://crrev.com/3345574ddb50494df05d1ed8579d51415863d506
Cr-Commit-Position: refs/heads/master@{#420569}

[hans, 2016-09-22 23:58:50]

hans@chromium.org changed reviewers:
+ thakis@chromium.org

[hans, 2016-09-22 23:58:51]

Please take a look.

[hans, 2016-09-23 00:07:50]

hans@chromium.org changed reviewers:
+ brettw@chromium.org, dpranke@chromium.org, scottmg@chromium.org

[hans, 2016-09-23 00:07:51]

+some more folks from the owners file

first to stamp wins

[Dirk Pranke, 2016-09-23 00:10:10]

Can you wait for https://codereview.chromium.org/2357483002/ to land (which is
in the CQ now) and then rebase on top of it? 

The naming conventions are changing ...

[hans, 2016-09-23 00:12:00]

On 2016/09/23 00:10:10, Dirk Pranke wrote:
> Can you wait for https://codereview.chromium.org/2357483002/ to land (which is
> in the CQ now) and then rebase on top of it? 
> 
> The naming conventions are changing ...

Sure! Thanks for the heads up.

[Nico, 2016-09-23 00:31:20]

Note that Hans landed a change to that file earlier today already, so not
sure if waiting buys anything

On Sep 22, 2016 8:10 PM, <dpranke@chromium.org> wrote:

> Can you wait for https://codereview.chromium.org/2357483002/ to land
> (which is
> in the CQ now) and then rebase on top of it?
>
> The naming conventions are changing ...
>
> https://codereview.chromium.org/2358083004/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[hans, 2016-09-23 00:34:24]

https://codereview.chromium.org/2357483002/ seems to be based on top of my
change

i'll just wait for it to land

On 2016/09/23 00:31:20, Nico wrote:
> Note that Hans landed a change to that file earlier today already, so not
> sure if waiting buys anything
> 
> On Sep 22, 2016 8:10 PM, <mailto:dpranke@chromium.org> wrote:
> 
> > Can you wait for https://codereview.chromium.org/2357483002/ to land
> > (which is
> > in the CQ now) and then rebase on top of it?
> >
> > The naming conventions are changing ...
> >
> > https://codereview.chromium.org/2358083004/
> >

[hans, 2016-09-23 01:54:47]

Rebased.

[Dirk Pranke, 2016-09-23 01:59:54]

lgtm. thanks!

[hans, 2016-09-23 02:11:14]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2016-09-23 02:11:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 03:51:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-23 03:53:09]

Description was changed from

==========
mb: Add a recipe for the chromium.perf.fyi Win Clang Builder

BUG=649539
==========

to

==========
mb: Add a recipe for the chromium.perf.fyi Win Clang Builder

BUG=649539

Committed: https://crrev.com/3345574ddb50494df05d1ed8579d51415863d506
Cr-Commit-Position: refs/heads/master@{#420569}
==========

[commit-bot: I haz the power, 2016-09-23 03:53:10]

Patchset 2 (id:??) landed as
https://crrev.com/3345574ddb50494df05d1ed8579d51415863d506
Cr-Commit-Position: refs/heads/master@{#420569}

[Dirk Pranke, 2016-09-23 23:27:11]

Argh, I thought I published this comment before the change landed :(.

https://codereview.chromium.org/2358083004/diff/20001/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/2358083004/diff/20001/tools/mb/mb_config.pyl#...
tools/mb/mb_config.pyl:297: 'Win Clang Builder': 'official_clang',
Actually, to confirm ... this won't use goma, and won't get you minimal_symbols.
Is that what you want?

[hans, 2016-09-26 21:03:30]

https://codereview.chromium.org/2358083004/diff/20001/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/2358083004/diff/20001/tools/mb/mb_config.pyl#...
tools/mb/mb_config.pyl:297: 'Win Clang Builder': 'official_clang',
On 2016/09/23 23:27:11, Dirk Pranke wrote:
> Actually, to confirm ... this won't use goma, and won't get you
minimal_symbols.
> Is that what you want?

Following up in https://codereview.chromium.org/2371953002