Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Issue 2371953002: mb: Enable goma and minimal_symbols for perf.fyi Win Clang Builder (Closed)

Created:
4 years, 2 months ago by hans
Modified:
4 years, 2 months ago
Reviewers:
Dirk Pranke, Nico
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mb: Enable goma and minimal_symbols for perf.fyi Win Clang Builder BUG=649539 Committed: https://crrev.com/ceeb603d5fbdb401a38921f7d5836388e8f75bfd Cr-Commit-Position: refs/heads/master@{#421280}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M tools/mb/mb_config.pyl View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
hans
It seems the non-clang win builder doesn't have minimal_symbols set, but let's try it for ...
4 years, 2 months ago (2016-09-26 21:04:55 UTC) #2
hans
Ping?
4 years, 2 months ago (2016-09-27 16:22:29 UTC) #3
Nico
On 2016/09/27 16:22:29, hans wrote: > Ping? Rs-lgtm
4 years, 2 months ago (2016-09-27 16:55:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2371953002/1
4 years, 2 months ago (2016-09-27 17:30:35 UTC) #6
Dirk Pranke
lgtm, sorry for the delay (ended up being out mostly yesterday).
4 years, 2 months ago (2016-09-27 18:14:43 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 18:42:20 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 18:48:28 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ceeb603d5fbdb401a38921f7d5836388e8f75bfd
Cr-Commit-Position: refs/heads/master@{#421280}

Powered by Google App Engine
This is Rietveld 408576698