Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 2357973002: Reland of Create Monochrome-specific repack() targets (Closed)

Created:
4 years, 3 months ago by agrieve
Modified:
4 years, 3 months ago
Reviewers:
michaelbai, Benoit L, brettw
CC:
chromium-reviews, alemate+watch_chromium.org, dtseng+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, android-webview-reviews_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Create Monochrome-specific repack() targets Reverted in: https://codereview.chromium.org/2353553004/ Reason for reland: Now tested with arm64 This allows Monochrome.apk's .pak files to properly contain the union of Chrome and WebView's .pak files. It also allows it to use a target-specific resource whitelist. This change applies to resources.pak and chrome_100_percent.pak. A change to language .pak files will come as a follow-up. TBR=michaelbai@chromium.org,brettw@chromium.org,lizeb@chromium.org BUG=641032, 634358, 648878 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/5fce4ef2072549d268a77e23210c4ec673a1c4c6 Cr-Commit-Position: refs/heads/master@{#420090}

Patch Set 1 #

Patch Set 2 : fix arm64 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -111 lines) Patch
M build/config/android/internal_rules.gni View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/BUILD.gn View 1 4 chunks +1 line, -23 lines 0 comments Download
M chrome/android/BUILD.gn View 1 5 chunks +79 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_paks.gni View 1 4 chunks +99 lines, -68 lines 0 comments Download
M chrome/test/BUILD.gn View 1 9 chunks +5 lines, -16 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
agrieve
Created Reland of Create Monochrome-specific repack() targets
4 years, 3 months ago (2016-09-21 14:07:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2357973002/120001
4 years, 3 months ago (2016-09-21 16:05:26 UTC) #5
brettw
lgtm
4 years, 3 months ago (2016-09-21 16:15:24 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:120001)
4 years, 3 months ago (2016-09-21 17:22:21 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 17:25:36 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5fce4ef2072549d268a77e23210c4ec673a1c4c6
Cr-Commit-Position: refs/heads/master@{#420090}

Powered by Google App Engine
This is Rietveld 408576698