Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2355073002:
Remove non-existent .pak for OS=mac in browser_tests (Closed)
DescriptionRemove non-existent .pak for OS=mac in browser_tests
TBR=thakis
BUG=648611
Committed: https://crrev.com/5283e20bada500fa875685719138e2d6272351ce
Cr-Commit-Position: refs/heads/master@{#420058}
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : rebase #
Total comments: 4
Dependent Patchsets: Messages
Total messages: 20 (13 generated)
The CQ bit was checked by agrieve@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
agrieve@chromium.org changed reviewers: + thakis@chromium.org
On 2016/09/20 20:13:42, agrieve wrote: Bots in ps1 seem to be having issues (most builds seem to be failing, not just this patch). But notably, mac_chromium_asan_rel_ng passed.
The CQ bit was checked by agrieve@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Remove non-existent .pak for OS=mac in browser_tests BUG=648611 ========== to ========== Remove non-existent .pak for OS=mac in browser_tests TBR=thakis BUG=648611 ==========
On 2016/09/20 20:14:36, agrieve wrote: > On 2016/09/20 20:13:42, agrieve wrote: > > Bots in ps1 seem to be having issues (most builds seem to be failing, not just > this patch). But notably, mac_chromium_asan_rel_ng passed. TBR to fix bot.
The CQ bit was checked by agrieve@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove non-existent .pak for OS=mac in browser_tests TBR=thakis BUG=648611 ========== to ========== Remove non-existent .pak for OS=mac in browser_tests TBR=thakis BUG=648611 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Remove non-existent .pak for OS=mac in browser_tests TBR=thakis BUG=648611 ========== to ========== Remove non-existent .pak for OS=mac in browser_tests TBR=thakis BUG=648611 Committed: https://crrev.com/5283e20bada500fa875685719138e2d6272351ce Cr-Commit-Position: refs/heads/master@{#420058} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/5283e20bada500fa875685719138e2d6272351ce Cr-Commit-Position: refs/heads/master@{#420058}
Message was sent while issue was closed.
lgtm, thanks. We're very consistent about this condition :-/ https://codereview.chromium.org/2355073002/diff/40001/chrome/test/BUILD.gn File chrome/test/BUILD.gn (right): https://codereview.chromium.org/2355073002/diff/40001/chrome/test/BUILD.gn#ne... chrome/test/BUILD.gn:451: if (is_linux || is_win) { 1 https://codereview.chromium.org/2355073002/diff/40001/chrome/test/BUILD.gn#ne... chrome/test/BUILD.gn:1957: if (!is_mac) { 2 https://codereview.chromium.org/2355073002/diff/40001/chrome/test/BUILD.gn#ne... chrome/test/BUILD.gn:2723: if (is_linux || is_win) { 3 https://codereview.chromium.org/2355073002/diff/40001/chrome/test/BUILD.gn#ne... chrome/test/BUILD.gn:3365: if (is_android || is_linux || is_win) { 4 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
