chrome/installer/gcapi/gcapi_omaha_experiment.h - Issue 23579003: GCAPI should append to the existing experiment_labels instead of clobbering them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/gcapi/gcapi_omaha_experiment.h

Issue 23579003: GCAPI should append to the existing experiment_labels instead of clobbering them. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Move Windows only variations_util code to variations_util_win Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/metrics/variations/variations_util_unittest.cc ('K') | « chrome/common/metrics/variations/variations_util_win.cc ('k') | chrome/installer/gcapi/gcapi_omaha_experiment.cc » ('j') | chrome/installer/gcapi/gcapi_omaha_experiment.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/gcapi/gcapi_omaha_experiment.h

diff --git a/chrome/installer/gcapi/gcapi_omaha_experiment.h b/chrome/installer/gcapi/gcapi_omaha_experiment.h

index babe41e3a9bee9e527e41257302687bcfbeacbd1..709b9d7f3df8bdb40a4f15a0f6e128e2c34a7c8b 100644

--- a/chrome/installer/gcapi/gcapi_omaha_experiment.h

+++ b/chrome/installer/gcapi/gcapi_omaha_experiment.h

@@ -5,6 +5,19 @@

#ifndef CHROME_INSTALLER_GCAPI_GCAPI_OMAHA_EXPERIMENT_H_

#define CHROME_INSTALLER_GCAPI_GCAPI_OMAHA_EXPERIMENT_H_

+#include "base/strings/string16.h"

+namespace gcapi_internals {

+extern const wchar_t kReactivationLabel[];

+extern const wchar_t kRelaunchLabel[];

+// Returns the experiment label to be used by |label| for |brand_code|.

Alexei Svitkine (slow) 2013/09/03 15:46:35 This comment is confusing. The experiment label to

gab 2013/11/05 22:20:38 Clarified.

+string16 GetGCAPIExperimentLabel(const wchar_t* brand_code,

+ const string16& label);

// Writes a reactivation brand code experiment label in the Chrome product and

// binaries registry keys for |brand_code|. This experiment label will have a

// expiration date of now plus one year. If |shell_mode| is set to