Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: chrome/installer/gcapi/gcapi_omaha_experiment.h

Issue 23579003: GCAPI should append to the existing experiment_labels instead of clobbering them. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Move Windows only variations_util code to variations_util_win Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_INSTALLER_GCAPI_GCAPI_OMAHA_EXPERIMENT_H_ 5 #ifndef CHROME_INSTALLER_GCAPI_GCAPI_OMAHA_EXPERIMENT_H_
6 #define CHROME_INSTALLER_GCAPI_GCAPI_OMAHA_EXPERIMENT_H_ 6 #define CHROME_INSTALLER_GCAPI_GCAPI_OMAHA_EXPERIMENT_H_
7 7
8 #include "base/strings/string16.h"
9
10 namespace gcapi_internals {
11
12 extern const wchar_t kReactivationLabel[];
13 extern const wchar_t kRelaunchLabel[];
14
15 // Returns the experiment label to be used by |label| for |brand_code|.
Alexei Svitkine (slow) 2013/09/03 15:46:35 This comment is confusing. The experiment label to
gab 2013/11/05 22:20:38 Clarified.
16 string16 GetGCAPIExperimentLabel(const wchar_t* brand_code,
17 const string16& label);
18
19 }
20
8 // Writes a reactivation brand code experiment label in the Chrome product and 21 // Writes a reactivation brand code experiment label in the Chrome product and
9 // binaries registry keys for |brand_code|. This experiment label will have a 22 // binaries registry keys for |brand_code|. This experiment label will have a
10 // expiration date of now plus one year. If |shell_mode| is set to 23 // expiration date of now plus one year. If |shell_mode| is set to
11 // GCAPI_INVOKED_UAC_ELEVATION, the value will be written to HKLM, otherwise 24 // GCAPI_INVOKED_UAC_ELEVATION, the value will be written to HKLM, otherwise
12 // HKCU. A user cannot have both a reactivation label and a relaunch label set 25 // HKCU. A user cannot have both a reactivation label and a relaunch label set
13 // at the same time (they are mutually exclusive). 26 // at the same time (they are mutually exclusive).
14 bool SetReactivationExperimentLabels(const wchar_t* brand_code, int shell_mode); 27 bool SetReactivationExperimentLabels(const wchar_t* brand_code, int shell_mode);
15 28
16 // Writes a relaunch brand code experiment label in the Chrome product and 29 // Writes a relaunch brand code experiment label in the Chrome product and
17 // binaries registry keys for |brand_code|. This experiment label will have a 30 // binaries registry keys for |brand_code|. This experiment label will have a
18 // expiration date of now plus one year. If |shell_mode| is set to 31 // expiration date of now plus one year. If |shell_mode| is set to
19 // GCAPI_INVOKED_UAC_ELEVATION, the value will be written to HKLM, otherwise 32 // GCAPI_INVOKED_UAC_ELEVATION, the value will be written to HKLM, otherwise
20 // HKCU. A user cannot have both a reactivation label and a relaunch label set 33 // HKCU. A user cannot have both a reactivation label and a relaunch label set
21 // at the same time (they are mutually exclusive). 34 // at the same time (they are mutually exclusive).
22 bool SetRelaunchExperimentLabels(const wchar_t* brand_code, int shell_mode); 35 bool SetRelaunchExperimentLabels(const wchar_t* brand_code, int shell_mode);
23 36
24 #endif // CHROME_INSTALLER_GCAPI_GCAPI_OMAHA_EXPERIMENT_H_ 37 #endif // CHROME_INSTALLER_GCAPI_GCAPI_OMAHA_EXPERIMENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698