Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2357863002:
Update FPS selection for camera2 implementation. (Closed)
|
Created:
4 years, 3 months ago by sakal-chromium Modified:
3 years, 11 months ago CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdate FPS selection for camera2 implementation.
BUG=630266
Review-Url: https://codereview.chromium.org/2357863002
Cr-Commit-Position: refs/heads/master@{#442222}
Committed: https://chromium.googlesource.com/chromium/src/+/7bac8124646aede47a34fe5d97a9355b9d82c151
Patch Set 1 : Fix a typo in a comment. #
Total comments: 4
Patch Set 2 : Use common implementation of getClosesFramerateRange. #Patch Set 3 : Add check for if fpsRanges is empty. #
Total comments: 2
Patch Set 4 : Make touched variables final. #Patch Set 5 : Also use getClosestSupportedFramerateRange from WebRTC. #Patch Set 6 : Revert last patch, rebase on master. #Messages
Total messages: 27 (16 generated)
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
PTAL Please note that I am not quite sure about the behavior with mExposureMode equal to NONE or FIXED and didn't find any use cases for it so I wasn't able to test it.
sakal@chromium.org changed reviewers: + magjed@chromium.org
Oops, forgot to add reviewer. PTAL Please note that I am not quite sure about the behavior with mExposureMode equal to NONE or FIXED and didn't find any use cases for it so I wasn't able to test it.
The CQ bit was checked by sakal@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
mcasas@chromium.org changed reviewers: + mcasas@chromium.org
https://codereview.chromium.org/2357863002/diff/40001/media/capture/video/and... File media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java (right): https://codereview.chromium.org/2357863002/diff/40001/media/capture/video/and... media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java:364: requestBuilder.set(CaptureRequest.SENSOR_EXPOSURE_TIME, This can only be set _after_ l.369 [1]. Also, why force the exposure time? What if you programmed a range of capture fps with the newly introduced algorithm? ToT doesn't configure the exposure mode when FIXED, it simply "locks" it to whatever value it has at the moment. [1] https://developer.android.com/reference/android/hardware/camera2/CaptureReque... https://codereview.chromium.org/2357863002/diff/40001/media/capture/video/and... media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java:602: private static Range<Integer> getClosestFpsRange( This code is the same as the one in https://codereview.chromium.org/2354923002/, please factor them out to a common location, and also mention where it comes from in webrtc in the header comment.
The CQ bit was checked by sakal@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
https://codereview.chromium.org/2357863002/diff/40001/media/capture/video/and... File media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java (right): https://codereview.chromium.org/2357863002/diff/40001/media/capture/video/and... media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java:364: requestBuilder.set(CaptureRequest.SENSOR_EXPOSURE_TIME, On 2016/09/21 16:15:55, mcasas wrote: > This can only be set _after_ l.369 [1]. Also, > why force the exposure time? What if you > programmed a range of capture fps with the > newly introduced algorithm? ToT doesn't > configure the exposure mode when FIXED, > it simply "locks" it to whatever value it has > at the moment. > > [1] > https://developer.android.com/reference/android/hardware/camera2/CaptureReque... Reverted to old behaviour. https://codereview.chromium.org/2357863002/diff/40001/media/capture/video/and... media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java:602: private static Range<Integer> getClosestFpsRange( On 2016/09/21 16:15:55, mcasas wrote: > This code is the same as the one in > https://codereview.chromium.org/2354923002/, > please factor them out to a common location, and > also mention where it comes from in webrtc in the > header comment. Done.
Ping mcasas.
pending https://codereview.chromium.org/2354923002/ lgtm https://codereview.chromium.org/2357863002/diff/80001/media/capture/video/and... File media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java (right): https://codereview.chromium.org/2357863002/diff/80001/media/capture/video/and... media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java:569: List<Range<Integer>> fpsRanges = Arrays.asList(cameraCharacteristics.get( Use final wherever possible.
https://codereview.chromium.org/2357863002/diff/80001/media/capture/video/and... File media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java (right): https://codereview.chromium.org/2357863002/diff/80001/media/capture/video/and... media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java:569: List<Range<Integer>> fpsRanges = Arrays.asList(cameraCharacteristics.get( On 2016/09/29 21:28:18, mcasas wrote: > Use final wherever possible. Done.
Rebased on master, PTAL.
The CQ bit was checked by magjed@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mcasas@chromium.org, magjed@chromium.org Link to the patchset: https://codereview.chromium.org/2357863002/#ps140001 (title: "Revert last patch, rebase on master.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 140001, "attempt_start_ts": 1483952429297620,
"parent_rev": "cab7ef9c241ae9e42cea3b6860bf724f5b5d8fca", "commit_rev":
"7bac8124646aede47a34fe5d97a9355b9d82c151"}
Message was sent while issue was closed.
Description was changed from ========== Update FPS selection for camera2 implementation. BUG=630266 ========== to ========== Update FPS selection for camera2 implementation. BUG=630266 Review-Url: https://codereview.chromium.org/2357863002 Cr-Commit-Position: refs/heads/master@{#442222} Committed: https://chromium.googlesource.com/chromium/src/+/7bac8124646aede47a34fe5d97a9... ==========
Message was sent while issue was closed.
Committed patchset #6 (id:140001) as https://chromium.googlesource.com/chromium/src/+/7bac8124646aede47a34fe5d97a9... |
