Issue 23578025: Remove useless calls to v8::Value::ToString()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23578025: Remove useless calls to v8::Value::ToString() (Closed)

Created:
7 years, 3 months ago by do-not-use

Modified:
7 years, 3 months ago

Reviewers:
haraken

CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, Nate Chapin, do-not-use

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove useless calls to v8::Value::ToString() Remove useless calls to v8::Value::ToString() after we already checked that v8::Value::IsString() already returns true. Use v8::Handle::As<v8::String>() instead, which is more efficient as it does not call v8::Value::IsString() again. R=haraken BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157678

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -3 lines)			Patch
M	Source/bindings/v8/ScriptDebugServer.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/v8/V8NPUtils.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/v8/custom/V8WindowCustom.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

haraken

LGTM. Another thing is that we're inconsistently mixing .As() and .Cast() in the code base. ...

7 years, 3 months ago (2013-09-12 12:35:18 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23578025/1

7 years, 3 months ago (2013-09-12 12:37:44 UTC) #3

Message was sent while issue was closed.

Change committed as 157678

Expand Messages | Collapse Messages