Source/bindings/v8/V8NPUtils.cpp - Issue 23578025: Remove useless calls to v8::Value::ToString()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8NPUtils.cpp

Issue 23578025: Remove useless calls to v8::Value::ToString() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/V8NPUtils.cpp

diff --git a/Source/bindings/v8/V8NPUtils.cpp b/Source/bindings/v8/V8NPUtils.cpp

index eb2e1a5cc800951a4e2bb2cf4697ef2c8d301536..01a740f4e4bb40b74d873b479fb29d07f33c30f2 100644

--- a/Source/bindings/v8/V8NPUtils.cpp

+++ b/Source/bindings/v8/V8NPUtils.cpp

@@ -61,7 +61,7 @@ void convertV8ObjectToNPVariant(v8::Local<v8::Value> object, NPObject* owner, NP

else if (object->IsUndefined())

VOID_TO_NPVARIANT(*result);

else if (object->IsString()) {

- v8::Handle<v8::String> str = object->ToString();

+ v8::Handle<v8::String> str = object.As<v8::String>();

int length = str->Utf8Length() + 1;

char* utf8Chars = reinterpret_cast<char*>(malloc(length));

str->WriteUtf8(utf8Chars, length, 0, v8::String::HINT_MANY_WRITES_EXPECTED);