Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2357783002:
Remove console viewport test from expectations after fix (Closed)
DescriptionRemove console viewport test from expectations after fix
When scroll anchoring was promoted to experimental status, it broke viewport
related LayoutTests, so expectations were updated for their failure. Now that
the tests have been fixed, the expectations need to be updated.
Promotion CL:
https://codereview.chromium.org/2291653002
Tests fixed CL:
https://codereview.chromium.org/2317343006
BUG=624534
Committed: https://crrev.com/2d42a22c81372bb8f3ffb685ad6c66bcb205a3a5
Cr-Commit-Position: refs/heads/master@{#420110}
Patch Set 1 #
Messages
Total messages: 17 (9 generated)
Description was changed from ========== remove viewport test from expectations BUG=624534 ========== to ========== Remove console viewport test from expectations after fix When scroll anchoring was promoted to experimental status, it broke viewport related LayoutTests, so expectations were updated for their failure. Now that the tests have been fixed, the expectations need to be updated. Promotion CL: https://codereview.chromium.org/2291653002 Tests fixed CL: https://codereview.chromium.org/2317343006 BUG=624534 ==========
luoe@chromium.org changed reviewers: + lushnikov@chromium.org, skobes@chromium.org, ymalik@chromium.org
It seems that after the tests were fixed in https://codereview.chromium.org/2317343006/ we didn't update TestExpectations. This CL removes the failure expectations since they now pass reliably.
lgtm Oops... sorry I forgot to do this. :)
The CQ bit was checked by luoe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
As a reviewer, I forgot to check this too!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by luoe@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove console viewport test from expectations after fix When scroll anchoring was promoted to experimental status, it broke viewport related LayoutTests, so expectations were updated for their failure. Now that the tests have been fixed, the expectations need to be updated. Promotion CL: https://codereview.chromium.org/2291653002 Tests fixed CL: https://codereview.chromium.org/2317343006 BUG=624534 ========== to ========== Remove console viewport test from expectations after fix When scroll anchoring was promoted to experimental status, it broke viewport related LayoutTests, so expectations were updated for their failure. Now that the tests have been fixed, the expectations need to be updated. Promotion CL: https://codereview.chromium.org/2291653002 Tests fixed CL: https://codereview.chromium.org/2317343006 BUG=624534 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove console viewport test from expectations after fix When scroll anchoring was promoted to experimental status, it broke viewport related LayoutTests, so expectations were updated for their failure. Now that the tests have been fixed, the expectations need to be updated. Promotion CL: https://codereview.chromium.org/2291653002 Tests fixed CL: https://codereview.chromium.org/2317343006 BUG=624534 ========== to ========== Remove console viewport test from expectations after fix When scroll anchoring was promoted to experimental status, it broke viewport related LayoutTests, so expectations were updated for their failure. Now that the tests have been fixed, the expectations need to be updated. Promotion CL: https://codereview.chromium.org/2291653002 Tests fixed CL: https://codereview.chromium.org/2317343006 BUG=624534 Committed: https://crrev.com/2d42a22c81372bb8f3ffb685ad6c66bcb205a3a5 Cr-Commit-Position: refs/heads/master@{#420110} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/2d42a22c81372bb8f3ffb685ad6c66bcb205a3a5 Cr-Commit-Position: refs/heads/master@{#420110}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2356263003/ by dewittj@chromium.org. The reason for reverting is: console-viewport-selection.html is still failing: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/7.... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
