Promote Scroll Anchoring to experimental

Promote Scroll Anchoring to experimental

BUG=597479
Committed: https://crrev.com/c8d07b366c6d97e2df003fc1960e09543b05285f
Cr-Commit-Position: refs/heads/master@{#418408}

[ymalik, 2016-09-12 21:13:19]

Description was changed from

==========
Promote Scroll Anchoring to experimental

BUG=597479
==========

to

==========
Promote Scroll Anchoring to experimental

Blocked on landing https://codereview.chromium.org/2317343006/,  which fixes the
DevTools test failure.

BUG=597479
==========

[ymalik, 2016-09-12 21:23:06]

ymalik@chromium.org changed reviewers:
+ ojan@chromium.org, skobes@chromium.org

[ymalik, 2016-09-12 21:23:35]

ymalik@chromium.org changed reviewers:
- ojan@chromium.org

[skobes, 2016-09-12 23:03:06]

lgtm

[skobes, 2016-09-13 18:18:12]

I think we shouldn't block this on https://codereview.chromium.org/2317343006/. 
Let's just mark those two tests as failing for now.

[ymalik, 2016-09-13 18:39:28]

On 2016/09/13 18:18:12, skobes wrote:
> I think we shouldn't block this on
https://codereview.chromium.org/2317343006/. 
> Let's just mark those two tests as failing for now.

Okay. This is still blocked on https://codereview.chromium.org/2336823003/.

[ymalik, 2016-09-13 19:15:16]

On 2016/09/13 18:39:28, ymalik wrote:
> On 2016/09/13 18:18:12, skobes wrote:
> > I think we shouldn't block this on
> https://codereview.chromium.org/2317343006/. 
> > Let's just mark those two tests as failing for now.
> 
> Okay. This is still blocked on https://codereview.chromium.org/2336823003/.

@skobes, PTAL. I guess its not strictly blocked on
https://codereview.chromium.org/2336823003/. I updated the test so that scroll
anchoring is not triggered. Also added failure expectation.

[ymalik, 2016-09-13 19:16:48]

Description was changed from

==========
Promote Scroll Anchoring to experimental

Blocked on landing https://codereview.chromium.org/2317343006/,  which fixes the
DevTools test failure.

BUG=597479
==========

to

==========
Promote Scroll Anchoring to experimental

BUG=597479
==========

[skobes, 2016-09-13 19:17:06]

lgtm

[ymalik, 2016-09-13 19:18:58]

ymalik@chromium.org changed reviewers:
+ vollick@chromium.org

[ymalik, 2016-09-13 19:18:59]

+vollick for Source/platform

[jbroman, 2016-09-13 21:45:45]

jbroman@chromium.org changed reviewers:
+ jbroman@chromium.org

[jbroman, 2016-09-13 21:45:46]

platform lgtm

[ymalik, 2016-09-13 21:46:24]

ymalik@chromium.org changed reviewers:
- vollick@chromium.org

[ymalik, 2016-09-13 21:46:32]

The CQ bit was checked by ymalik@chromium.org

[commit-bot: I haz the power, 2016-09-13 21:47:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ojan, 2016-09-13 21:52:08]

ojan@chromium.org changed reviewers:
+ ojan@chromium.org

[ojan, 2016-09-13 21:52:09]

https://codereview.chromium.org/2291653002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in (right):

https://codereview.chromium.org/2291653002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in:194:
ScrollAnchoring status=experimental, settable_from_internals=True
IIRC, experimental just means that it'll be enabled for anyone who turns on the
--enabled-experimental-web-platform-features flag. Is that what you were going
for? If not, I think you want status=stable.

[skobes, 2016-09-13 21:53:32]

On 2016/09/13 21:52:09, ojan wrote:
>
https://codereview.chromium.org/2291653002/diff/60001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in (right):
> 
>
https://codereview.chromium.org/2291653002/diff/60001/third_party/WebKit/Sour...
> third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in:194:
> ScrollAnchoring status=experimental, settable_from_internals=True
> IIRC, experimental just means that it'll be enabled for anyone who turns on
the
> --enabled-experimental-web-platform-features flag. Is that what you were going
> for? If not, I think you want status=stable.

I think we're doing that part in a separate change, right Yash?

[ojan, 2016-09-13 21:56:45]

On 2016/09/13 at 21:53:32, skobes wrote:
> On 2016/09/13 21:52:09, ojan wrote:
> >
https://codereview.chromium.org/2291653002/diff/60001/third_party/WebKit/Sour...
> > File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in (right):
> > 
> >
https://codereview.chromium.org/2291653002/diff/60001/third_party/WebKit/Sour...
> > third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in:194:
> > ScrollAnchoring status=experimental, settable_from_internals=True
> > IIRC, experimental just means that it'll be enabled for anyone who turns on
the
> > --enabled-experimental-web-platform-features flag. Is that what you were
going
> > for? If not, I think you want status=stable.
> 
> I think we're doing that part in a separate change, right Yash?

lgtm. Just wanted to sanity check that this is what you intended.

[ymalik, 2016-09-13 22:16:51]

On 2016/09/13 21:56:45, ojan wrote:
> On 2016/09/13 at 21:53:32, skobes wrote:
> > On 2016/09/13 21:52:09, ojan wrote:
> > >
>
https://codereview.chromium.org/2291653002/diff/60001/third_party/WebKit/Sour...
> > > File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in (right):
> > > 
> > >
>
https://codereview.chromium.org/2291653002/diff/60001/third_party/WebKit/Sour...
> > > third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in:194:
> > > ScrollAnchoring status=experimental, settable_from_internals=True
> > > IIRC, experimental just means that it'll be enabled for anyone who turns
on
> the
> > > --enabled-experimental-web-platform-features flag. Is that what you were
> going
> > > for? If not, I think you want status=stable.
> > 
> > I think we're doing that part in a separate change, right Yash?
> 
> lgtm. Just wanted to sanity check that this is what you intended.

That's correct. I figured that we would need this in the future anyway. This
ensures that the layout tests run with scroll anchoring enabled. The change that
would put this into stable can now be small and easily revertable.

[ojan, 2016-09-13 22:32:23]

Yup, makes sense.

On Tue, Sep 13, 2016, 3:16 PM <ymalik@chromium.org> wrote:

> On 2016/09/13 21:56:45, ojan wrote:
> > On 2016/09/13 at 21:53:32, skobes wrote:
> > > On 2016/09/13 21:52:09, ojan wrote:
> > > >
> >
>
>
https://codereview.chromium.org/2291653002/diff/60001/third_party/WebKit/Sour...
> > > > File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
> (right):
> > > >
> > > >
> >
>
>
https://codereview.chromium.org/2291653002/diff/60001/third_party/WebKit/Sour...
> > > > third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in:194:
> > > > ScrollAnchoring status=experimental, settable_from_internals=True
> > > > IIRC, experimental just means that it'll be enabled for anyone who
> turns
> on
> > the
> > > > --enabled-experimental-web-platform-features flag. Is that what you
> were
> > going
> > > > for? If not, I think you want status=stable.
> > >
> > > I think we're doing that part in a separate change, right Yash?
> >
> > lgtm. Just wanted to sanity check that this is what you intended.
>
> That's correct. I figured that we would need this in the future anyway.
> This
> ensures that the layout tests run with scroll anchoring enabled. The
> change that
> would put this into stable can now be small and easily revertable.
>
> https://codereview.chromium.org/2291653002/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[ojan, 2016-09-13 22:32:24]

Yup, makes sense.

On Tue, Sep 13, 2016, 3:16 PM <ymalik@chromium.org> wrote:

> On 2016/09/13 21:56:45, ojan wrote:
> > On 2016/09/13 at 21:53:32, skobes wrote:
> > > On 2016/09/13 21:52:09, ojan wrote:
> > > >
> >
>
>
https://codereview.chromium.org/2291653002/diff/60001/third_party/WebKit/Sour...
> > > > File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
> (right):
> > > >
> > > >
> >
>
>
https://codereview.chromium.org/2291653002/diff/60001/third_party/WebKit/Sour...
> > > > third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in:194:
> > > > ScrollAnchoring status=experimental, settable_from_internals=True
> > > > IIRC, experimental just means that it'll be enabled for anyone who
> turns
> on
> > the
> > > > --enabled-experimental-web-platform-features flag. Is that what you
> were
> > going
> > > > for? If not, I think you want status=stable.
> > >
> > > I think we're doing that part in a separate change, right Yash?
> >
> > lgtm. Just wanted to sanity check that this is what you intended.
>
> That's correct. I figured that we would need this in the future anyway.
> This
> ensures that the layout tests run with scroll anchoring enabled. The
> change that
> would put this into stable can now be small and easily revertable.
>
> https://codereview.chromium.org/2291653002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2016-09-13 23:23:44]

Description was changed from

==========
Promote Scroll Anchoring to experimental

BUG=597479
==========

to

==========
Promote Scroll Anchoring to experimental

BUG=597479
==========

[commit-bot: I haz the power, 2016-09-13 23:23:45]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-13 23:25:20]

Description was changed from

==========
Promote Scroll Anchoring to experimental

BUG=597479
==========

to

==========
Promote Scroll Anchoring to experimental

BUG=597479

Committed: https://crrev.com/c8d07b366c6d97e2df003fc1960e09543b05285f
Cr-Commit-Position: refs/heads/master@{#418408}
==========

[commit-bot: I haz the power, 2016-09-13 23:25:21]

Patchset 4 (id:??) landed as
https://crrev.com/c8d07b366c6d97e2df003fc1960e09543b05285f
Cr-Commit-Position: refs/heads/master@{#418408}