Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2357733003:
Include Closure Compiler in CQ bots for ui/file_manager. (Closed)
|
Created:
4 years, 3 months ago by fukino Modified:
4 years, 3 months ago CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org, Dan Beam Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionInclude Closure Compiler in CQ bots for ui/file_manager.
This adds:
Q_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
to CLs in ui/file_manager.
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/46ce6286c77030a95f50b20f5198da16d4cb05ab
Cr-Commit-Position: refs/heads/master@{#419986}
Patch Set 1 #
Messages
Total messages: 20 (10 generated)
Description was changed from ========== Include Closure Compiler in CQ bots for ui/file_manager. This adds: Q_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation to CLs for ui/file_manager. BUG=none ========== to ========== Include Closure Compiler in CQ bots for ui/file_manager. This adds: Q_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation to CLs for ui/file_manager. BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Include Closure Compiler in CQ bots for ui/file_manager. This adds: Q_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation to CLs for ui/file_manager. BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Include Closure Compiler in CQ bots for ui/file_manager. This adds: Q_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation to CLs in ui/file_manager. BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
fukino@chromium.org changed reviewers: + oka@chromium.org
PTAL
oka@google.com changed reviewers: + oka@google.com
lgtm LGTM
Thanks!
The CQ bit was checked by fukino@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by fukino@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Include Closure Compiler in CQ bots for ui/file_manager. This adds: Q_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation to CLs in ui/file_manager. BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Include Closure Compiler in CQ bots for ui/file_manager. This adds: Q_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation to CLs in ui/file_manager. BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Include Closure Compiler in CQ bots for ui/file_manager. This adds: Q_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation to CLs in ui/file_manager. BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Include Closure Compiler in CQ bots for ui/file_manager. This adds: Q_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation to CLs in ui/file_manager. BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/46ce6286c77030a95f50b20f5198da16d4cb05ab Cr-Commit-Position: refs/heads/master@{#419986} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/46ce6286c77030a95f50b20f5198da16d4cb05ab Cr-Commit-Position: refs/heads/master@{#419986}
Message was sent while issue was closed.
dbeam@chromium.org changed reviewers: + dbeam@chromium.org
Message was sent while issue was closed.
\o/ |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
