ui/file_manager/PRESUBMIT.py - Issue 2357733003: Include Closure Compiler in CQ bots for ui/file_manager.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/file_manager/PRESUBMIT.py

Issue 2357733003: Include Closure Compiler in CQ bots for ui/file_manager. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | no next file » | no next file with comments »

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import re	5 import re

6	6

7	7

8 def PostUploadHook(cl, change, output_api):	8 def PostUploadHook(cl, change, output_api):

9 rietveld_obj = cl.RpcServer()	9 rietveld_obj = cl.RpcServer()

10 description = rietveld_obj.get_description(cl.issue)	10 description = rietveld_obj.get_description(cl.issue)

11	11

12 existing_bots = (change.CQ_INCLUDE_TRYBOTS or '').split(';')	12 existing_bots = (change.CQ_INCLUDE_TRYBOTS or '').split(';')

13 clean_bots = set(filter(None, map(lambda s: s.strip(), existing_bots)))	13 clean_bots = set(filter(None, map(lambda s: s.strip(), existing_bots)))

14 new_bots = clean_bots \| set(	14 new_bots = clean_bots \| set(

15 ['master.tryserver.chromium.linux:closure_compilation'])	15 ['master.tryserver.chromium.linux:closure_compilation'])

16 new_tag = 'CQ_INCLUDE_TRYBOTS=%s' % ';'.join(new_bots)	16 new_tag = 'CQ_INCLUDE_TRYBOTS=%s' % ';'.join(new_bots)

17	17

18 if clean_bots:	18 if clean_bots:

19 tag_reg = '^CQ_INCLUDE_TRYBOTS=.*$'	19 tag_reg = '^CQ_INCLUDE_TRYBOTS=.*$'

20 new_description = re.sub(tag_reg, new_tag, description, flags=re.M \| re.I)	20 new_description = re.sub(tag_reg, new_tag, description, flags=re.M \| re.I)

21 else:	21 else:

22 new_description = description + '\n' + new_tag	22 new_description = description + '\n' + new_tag

23	23

24 if new_description == description:	24 if new_description == description:

25 return []	25 return []

26	26

27 rietveld_obj.update_description(cl.issue, new_description)	27 rietveld_obj.update_description(cl.issue, new_description)

28 return [output_api.PresubmitNotifyResult(	28 return [output_api.PresubmitNotifyResult(

29 'Automatically added optional Closure bots to run on CQ.')]	29 'Automatically added optional Closure bots to run on CQ.')]

OLD	NEW