Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: tools/chrome_proxy/common/chrome_proxy_measurements.py

Issue 2357723002: Add integration tests for QUIC (Closed)
Patch Set: ps Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/chrome_proxy/common/chrome_proxy_measurements.py
diff --git a/tools/chrome_proxy/common/chrome_proxy_measurements.py b/tools/chrome_proxy/common/chrome_proxy_measurements.py
index 58d7faa5a03c688da589466d2c640a268b189e1f..5e28754ba1040d0f227533770a0ff794e38504c4 100644
--- a/tools/chrome_proxy/common/chrome_proxy_measurements.py
+++ b/tools/chrome_proxy/common/chrome_proxy_measurements.py
@@ -80,9 +80,6 @@ class ChromeProxyValidation(page_test.PageTest):
options.AppendExtraBrowserArgs('--enable-spdy-proxy-auth')
self._is_chrome_proxy_enabled = True
- # Disable quic option, otherwise request headers won't be visible.
- options.AppendExtraBrowserArgs('--disable-quic')
bustamante 2016/09/21 18:50:12 I think we need this for every test, since the qui
RyanSturm 2016/09/21 18:56:24 I think he adds the command individually to the te
bustamante 2016/09/21 19:11:42 All tests can do header validation if the --extra-
tbansal1 2016/09/22 17:25:42 Looking at AddResultsForExtraViaHeader function, i
-
def DisableChromeProxy(self):
self.options.browser_options.extra_browser_args.discard(
'--enable-spdy-proxy-auth')

Powered by Google App Engine
This is Rietveld 408576698