Add integration tests for QUIC

tools/chrome_proxy/common/chrome_proxy_measurements.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import base64
 import logging
 
 from common import chrome_proxy_metrics as metrics
 from telemetry.core import exceptions
 from telemetry.page import page_test
@@ skipping 62 matching lines @@
         needs_browser_restart_after_each_page=restart_after_each_page,
         clear_cache_before_each_run=clear_cache_before_each_run)
     self._metrics = metrics
     self._page = None
 
   def CustomizeBrowserOptions(self, options):
     # Enable the chrome proxy (data reduction proxy).
     options.AppendExtraBrowserArgs('--enable-spdy-proxy-auth')
     self._is_chrome_proxy_enabled = True
 
-    # Disable quic option, otherwise request headers won't be visible.
-    options.AppendExtraBrowserArgs('--disable-quic')

[bustamante, 2016/09/21 18:50:12]

I think we need this for every test, since the quic experiment being enabled
(which was happening occasionally) blocks header validation.  For example, when
an integration test runs on staging all tests will validate that the "1.1
Chrome-Compression-Proxy-Testing" via header appears in responses.

[RyanSturm, 2016/09/21 18:56:24]

I think he adds the command individually to the tests that do header validation.

[bustamante, 2016/09/21 19:11:42]

All tests can do header validation if the --extra-chrome-proxy-via-header flag
is used.

But also I don't think it's obvious that someone has to know to add a
--disable-quic flag if they want to do header validation, so it's going to lead
to more flaking down the road - like crbug.com/593331

[tbansal1, 2016/09/22 17:25:42]

Looking at AddResultsForExtraViaHeader function, it seems it only checks the
response headers (and not the request headers). So, that should work correctly
even if QUIC is in use, since usage of QUIC only makes the request headers
difficult to look up.
For now, I have put this flag back. However, I have kept the --disable-quic in
the individual tests that actually look at the request headers. That way we can
easily remove the global --disable-quic flag in the future (if there is a need),
without breaking any tests.

-
   def DisableChromeProxy(self):
     self.options.browser_options.extra_browser_args.discard(
                 '--enable-spdy-proxy-auth')
     self._is_chrome_proxy_enabled = False
 
   def WillNavigateToPage(self, page, tab):
     if self._is_chrome_proxy_enabled:
       WaitForViaHeader(tab)
 
     if self.clear_cache_before_each_run:
@@ skipping 12 matching lines @@
           tab, results, ChromeProxyValidation.extra_via_header)
     self.AddResults(tab, results)
 
   def AddResults(self, tab, results):
     raise NotImplementedError
 
   def StopBrowserAfterPage(self, browser, page):  # pylint: disable=W0613
     if hasattr(page, 'restart_after') and page.restart_after:
       return True
     return False