Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 2357703002: GN: add skia_use_mesa for OSMesa in tools. (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: add skia_use_mesa for OSMesa in tools. I tested by running $ out/dm --src gm --config mesa $ out/nanobench --config mesa --match Xfermode ... but I ran out of patience waiting for nanobench to finish. Probably works. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2357703002 Committed: https://skia.googlesource.com/skia/+/a627b5c3b9004118621bfa99f3952465adfa4ad6

Patch Set 1 #

Patch Set 2 : we gn now #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -9 lines) Patch
M BUILD.gn View 4 chunks +10 lines, -0 lines 0 comments Download
M infra/bots/recipe_modules/flavor/gn_flavor.py View 1 2 chunks +3 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-x86_64-Release-Mesa.json View 1 1 chunk +28 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
mtklein_C
4 years, 3 months ago (2016-09-20 19:33:39 UTC) #4
bsalomon
lgtm
4 years, 3 months ago (2016-09-20 19:35:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2357703002/20001
4 years, 3 months ago (2016-09-20 19:49:51 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 20:36:49 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/a627b5c3b9004118621bfa99f3952465adfa4ad6

Powered by Google App Engine
This is Rietveld 408576698