Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 23576004: Don't send mail for policy_checklist comments. (Closed)

Created:
7 years, 3 months ago by Mattias Nissler (ping if slow)
Modified:
7 years, 3 months ago
Reviewers:
agable
CC:
chromium-reviews
Base URL:
https://git.chromium.org/git/chromium/tools/reviewbot.git@master
Visibility:
Public.

Description

Don't send mail for policy_checklist comments. This changes the policy_checklist review handler to not send mail when publishing comments. This is so patch authors don't receive nag mail, but reviewers have the review bot comments for reference. BUG=None R=agable@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219800

Patch Set 1 #

Total comments: 10

Patch Set 2 : Address comments. #

Patch Set 3 : Address feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -5 lines) Patch
M handlers/policy_checklist/handler.py View 1 2 2 chunks +14 lines, -1 line 0 comments Download
M rietveld.py View 1 1 chunk +8 lines, -4 lines 0 comments Download
M util.py View 1 2 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Mattias Nissler (ping if slow)
7 years, 3 months ago (2013-08-27 14:19:19 UTC) #1
agable
https://codereview.chromium.org/23576004/diff/1/handlers/policy_checklist/handler.py File handlers/policy_checklist/handler.py (right): https://codereview.chromium.org/23576004/diff/1/handlers/policy_checklist/handler.py#newcode41 handlers/policy_checklist/handler.py:41: for item in canonicalized Double-nested fors in list comprehensions ...
7 years, 3 months ago (2013-08-27 14:49:19 UTC) #2
Mattias Nissler (ping if slow)
https://codereview.chromium.org/23576004/diff/1/handlers/policy_checklist/handler.py File handlers/policy_checklist/handler.py (right): https://codereview.chromium.org/23576004/diff/1/handlers/policy_checklist/handler.py#newcode41 handlers/policy_checklist/handler.py:41: for item in canonicalized On 2013/08/27 14:49:19, Aaron Gable ...
7 years, 3 months ago (2013-08-27 15:08:41 UTC) #3
agable
https://codereview.chromium.org/23576004/diff/1/handlers/policy_checklist/handler.py File handlers/policy_checklist/handler.py (right): https://codereview.chromium.org/23576004/diff/1/handlers/policy_checklist/handler.py#newcode41 handlers/policy_checklist/handler.py:41: for item in canonicalized On 2013/08/27 15:08:41, Mattias Nissler ...
7 years, 3 months ago (2013-08-27 15:56:26 UTC) #4
Mattias Nissler (ping if slow)
https://codereview.chromium.org/23576004/diff/1/handlers/policy_checklist/handler.py File handlers/policy_checklist/handler.py (right): https://codereview.chromium.org/23576004/diff/1/handlers/policy_checklist/handler.py#newcode41 handlers/policy_checklist/handler.py:41: for item in canonicalized On 2013/08/27 15:56:26, Aaron Gable ...
7 years, 3 months ago (2013-08-27 16:07:23 UTC) #5
agable
Great, thanks! LGTM.
7 years, 3 months ago (2013-08-27 16:14:03 UTC) #6
Mattias Nissler (ping if slow)
7 years, 3 months ago (2013-08-27 16:17:12 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r219800 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698