Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Unified Diff: rietveld.py

Issue 23576004: Don't send mail for policy_checklist comments. (Closed) Base URL: https://git.chromium.org/git/chromium/tools/reviewbot.git@master
Patch Set: Address feedback. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « handlers/policy_checklist/handler.py ('k') | util.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: rietveld.py
diff --git a/rietveld.py b/rietveld.py
index 0e3d40540a99dcf8fd934240984e2c023e26b3fd..8cf29e679484fdad527a568f3d0be850f301cd4d 100644
--- a/rietveld.py
+++ b/rietveld.py
@@ -66,14 +66,18 @@ class Rietveld(object):
def post_issue_data(self, issue, req, payload):
return self.post_data('%s/%s' % (issue, req), payload)
- def post_comment(self, issue, comment, submit_inline_comments=False):
+ def publish_inline_comments(self, issue, comment, reviewers, cc,
+ subject=None, send_mail=False):
publish_payload = {
- 'message_only': 0 if submit_inline_comments else 1,
- 'send_mail': 1,
- 'add_as_reviewer': 0,
+ 'cc': cc,
'message': comment,
+ 'message_only': 0,
'no_redirect': 1,
+ 'reviewers': reviewers,
+ 'send_mail': 1 if send_mail else 0,
}
+ if subject is not None:
+ publish_payload['subject'] = subject
self.post_issue_data(issue, 'publish', publish_payload)
def add_inline_comment(self, issue_id, patchset_id, patch_id, line, a_or_b,
« no previous file with comments | « handlers/policy_checklist/handler.py ('k') | util.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698