Issue 23575004: Refactor CreateDiretoryRequest.

Issue 23575004: Refactor CreateDiretoryRequest. (Closed)

Created:
7 years, 3 months ago by hidehiko

Modified:
7 years, 3 months ago

Reviewers:
tfarina, kinaba

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Refactor CreateDiretoryRequest. The operation is mapped to "Files: insert" on Drive API v2. To adapt the API more, renamed and changed the style. Note that the request may be reused for simple/multipart file uploading. BUG=277253 TEST=Ran unit_tests and tested manually. R=kinaba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220521

Patch Set 1 #

Patch Set 2 : Rebase #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+162 lines, -144 lines)			Patch
M	chrome/browser/drive/drive_api_service.cc	View	1	3 chunks	+11 lines, -8 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_requests.h	View	1	2 chunks	+43 lines, -27 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_requests.cc	View	1	2 chunks	+50 lines, -50 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_requests_unittest.cc	View	1	2 chunks	+44 lines, -44 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_url_generator.h	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_url_generator.cc	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_url_generator_unittest.cc	View	1	2 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

hidehiko

On 2013/08/29 17:05:38, tfarina wrote: > The BUG # linked is wrong! tfarina@, good catch! ...

7 years, 3 months ago (2013-08-29 17:57:02 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23575004/7001

7 years, 3 months ago (2013-08-30 02:21:46 UTC) #5

hidehiko

7 years, 3 months ago (2013-08-30 06:41:45 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r220521 (presubmit successful).

Expand Messages | Collapse Messages