Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: chrome/browser/drive/drive_api_service.cc

Issue 23575004: Refactor CreateDiretoryRequest. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/google_apis/drive_api_requests.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/drive/drive_api_service.cc
diff --git a/chrome/browser/drive/drive_api_service.cc b/chrome/browser/drive/drive_api_service.cc
index da9495c20e8e62a8c75688e5d2390781f8b272a0..cb05955a70d18f49485bc862a1e7c7240c814b63 100644
--- a/chrome/browser/drive/drive_api_service.cc
+++ b/chrome/browser/drive/drive_api_service.cc
@@ -55,11 +55,11 @@ using google_apis::drive::AboutGetRequest;
using google_apis::drive::AppsListRequest;
using google_apis::drive::ChangesListRequest;
using google_apis::drive::ContinueGetFileListRequest;
-using google_apis::drive::CreateDirectoryRequest;
using google_apis::drive::DeleteResourceRequest;
using google_apis::drive::DownloadFileRequest;
using google_apis::drive::FilesCopyRequest;
using google_apis::drive::FilesGetRequest;
+using google_apis::drive::FilesInsertRequest;
using google_apis::drive::FilesPatchRequest;
using google_apis::drive::FilesListRequest;
using google_apis::drive::GetUploadStatusRequest;
@@ -78,6 +78,9 @@ const char kDriveScope[] = "https://www.googleapis.com/auth/drive";
const char kDriveAppsReadonlyScope[] =
"https://www.googleapis.com/auth/drive.apps.readonly";
+// Mime type to create a directory.
+const char kFolderMimeType[] = "application/vnd.google-apps.folder";
+
// Expected max number of files resources in a http request.
// Be careful not to use something too small because it might overload the
// server. Be careful not to use something too large because it takes longer
@@ -603,13 +606,13 @@ CancelCallback DriveAPIService::AddNewDirectory(
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
DCHECK(!callback.is_null());
- return sender_->StartRequestWithRetry(
- new CreateDirectoryRequest(
- sender_.get(),
- url_generator_,
- parent_resource_id,
- directory_title,
- base::Bind(&ConvertFileEntryToResourceEntryAndRun, callback)));
+ FilesInsertRequest* request = new FilesInsertRequest(
+ sender_.get(), url_generator_,
+ base::Bind(&ConvertFileEntryToResourceEntryAndRun, callback));
+ request->set_mime_type(kFolderMimeType);
+ request->add_parent(parent_resource_id);
+ request->set_title(directory_title);
+ return sender_->StartRequestWithRetry(request);
}
CancelCallback DriveAPIService::CopyResource(
« no previous file with comments | « no previous file | chrome/browser/google_apis/drive_api_requests.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698