Add trusty builders on chromium.linux & tryserver.chromium.linux

Add trusty builders / testers on chromium.linux and tryserver.chromium.linux

BUG=644641
BUG=646285
BUG=640638
Committed: https://chromium.googlesource.com/chromium/tools/build/+/5a574e8e30189b6fd85db36dee941160244303f9

[Yoshisato Yanagisawa, 2016-09-21 08:39:52]

yyanagisawa@chromium.org changed reviewers:
+ phajdan.jr@chromium.org, tandrii@chromium.org

[tandrii(chromium), 2016-09-21 18:21:37]

this CL is how the waterfall should look like after upgrade to trusty is over.

But this has to be done at the same time as trusty upgrade on tryserver,
otherwise dev's CLs could be reverted after passing precise on CQ because they
fail on trusty.

So, the right way is, IMO, add a new trusty builder per existing precise one
(say with _trusty suffix), restart master and watch it for a week.

Them, if the builds on precise and trusty match for a week && tryserver is also
greenish, then land *this* CL and remove temporary trusty bots. Makes sense?

[Paweł Hajdan Jr., 2016-09-21 19:29:03]

+1 to what Andrii said

We should also have a ready set of Trusty trybots at roughly the same time, to
minimize the window we have to maintain *both* Precise and Trusty.

[Yoshisato Yanagisawa, 2016-09-28 03:08:19]

Description was changed from

==========
Replace precise with trusty on chromium.linux.

BUG=644641
BUG=646285
==========

to

==========
Add trusty builders on chromium.linux.

BUG=644641
BUG=646285
==========

[Yoshisato Yanagisawa, 2016-09-28 03:54:36]

Description was changed from

==========
Add trusty builders on chromium.linux.

BUG=644641
BUG=646285
==========

to

==========
Add trusty builders on chromium.linux.

BUG=644641
BUG=646285
==========

[Yoshisato Yanagisawa, 2016-09-28 03:56:15]

Ok, I changed the code in that way.  Then, this change should come after
followings:
https://codereview.chromium.org/2371373002/
https://codereview.chromium.org/2377933002/

[Yoshisato Yanagisawa, 2016-10-03 04:53:32]

Description was changed from

==========
Add trusty builders on chromium.linux.

BUG=644641
BUG=646285
==========

to

==========
Add trusty builders / testers on chromium.linux.

BUG=644641
BUG=646285
==========

[Yoshisato Yanagisawa, 2016-10-03 04:55:14]

The CQ bit was checked by yyanagisawa@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 04:55:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yoshisato Yanagisawa, 2016-10-03 04:56:04]

> https://codereview.chromium.org/2371373002/

this has been submitted.

> https://codereview.chromium.org/2377933002/

this has been merged to this because CQ rejected misamtch of master config and
recipes.

[commit-bot: I haz the power, 2016-10-03 05:02:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 05:02:13]

Dry run: Try jobs failed on following builders:
  Build Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/31a1b72f24fafc10)

[Yoshisato Yanagisawa, 2016-10-03 07:02:05]

The CQ bit was checked by yyanagisawa@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 07:02:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 07:10:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 07:10:18]

Dry run: Try jobs failed on following builders:
  Build Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/31a22b3c3226b710)

[Paweł Hajdan Jr., 2016-10-03 10:06:36]

LGTM ; make sure trybots pass

[Yoshisato Yanagisawa, 2016-10-04 01:26:43]

trybots fails by mismatches of tryserver.chromium.linux and chromium.linux.  I
need to set up trusty trybot before submitting this.
https://bugs.chromium.org/p/chromium/issues/detail?id=640638

[Yoshisato Yanagisawa, 2016-11-10 00:37:28]

mmm, ok, I should rebase.

[Yoshisato Yanagisawa, 2016-11-10 01:22:22]

The CQ bit was checked by yyanagisawa@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 01:22:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 02:02:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 02:03:00]

Dry run: Try jobs failed on following builders:
  Build Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/3264b83fe53f3010)

[Yoshisato Yanagisawa, 2016-11-10 04:11:57]

The CQ bit was checked by yyanagisawa@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 04:12:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yoshisato Yanagisawa, 2016-11-10 04:12:34]

The CQ bit was unchecked by yyanagisawa@chromium.org

[Yoshisato Yanagisawa, 2016-11-10 06:53:14]

The CQ bit was checked by yyanagisawa@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 06:53:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 07:33:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 07:33:48]

Dry run: Try jobs failed on following builders:
  Build Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/3265ddfdee27cb10)

[Yoshisato Yanagisawa, 2016-11-10 09:01:12]

The CQ bit was checked by yyanagisawa@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 09:01:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 09:41:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 09:41:55]

Dry run: Try jobs failed on following builders:
  Build Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/3266532372c93e10)

[Yoshisato Yanagisawa, 2016-11-11 01:16:14]

The CQ bit was checked by yyanagisawa@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 01:16:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 01:58:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 01:59:00]

Dry run: Try jobs failed on following builders:
  Build Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/3269da99c4913510)

[Yoshisato Yanagisawa, 2016-11-11 02:20:08]

The CQ bit was checked by yyanagisawa@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 02:20:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 03:01:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 03:01:05]

Dry run: Try jobs failed on following builders:
  Build Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/326a13cb0e338610)

[Yoshisato Yanagisawa, 2016-11-11 04:30:56]

The CQ bit was checked by yyanagisawa@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 04:30:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 05:13:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 05:13:01]

Dry run: Try jobs failed on following builders:
  Build Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/326a78de857f1110)

[Yoshisato Yanagisawa, 2016-11-11 05:38:43]

Description was changed from

==========
Add trusty builders / testers on chromium.linux.

BUG=644641
BUG=646285
==========

to

==========
Add trusty builders / testers on chromium.linux and tryserver.chromium.linux

BUG=644641
BUG=646285
BUG=640638
==========

[Yoshisato Yanagisawa, 2016-11-11 05:38:57]

The CQ bit was checked by yyanagisawa@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 05:39:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 06:20:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 06:20:21]

Dry run: Try jobs failed on following builders:
  Build Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/326ab731969a1a10)

[Yoshisato Yanagisawa, 2016-11-11 08:43:30]

The CQ bit was checked by yyanagisawa@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 08:43:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 09:23:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 09:23:54]

Dry run: Try jobs failed on following builders:
  Build Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/326b69af812c4f10)

[Yoshisato Yanagisawa, 2016-11-11 09:32:15]

The CQ bit was checked by yyanagisawa@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 09:32:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 09:42:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 09:42:52]

Dry run: This issue passed the CQ dry run.

[Yoshisato Yanagisawa, 2016-11-14 01:28:42]

PTAL

Finally, I noticed that to update chromium.linux, I also need to update
tryserver.chromium.linux.  I updated tryserver.chromium.linux where its update
was enforced by update of chromium.linux.

[Paweł Hajdan Jr., 2016-11-14 09:41:34]

LGTM w/comments

https://codereview.chromium.org/2357493005/diff/200001/masters/master.chromiu...
File masters/master.chromium.linux/master_linux_cfg.py (right):

https://codereview.chromium.org/2357493005/diff/200001/masters/master.chromiu...
masters/master.chromium.linux/master_linux_cfg.py:41: 'Blimp Linux (dbg)',
Could you also add Trusty one for Blimp?

I'd be fine with a TODO in this CL to keep things moving.

https://codereview.chromium.org/2357493005/diff/200001/masters/master.tryserv...
File masters/master.tryserver.chromium.linux/slaves.cfg (right):

https://codereview.chromium.org/2357493005/diff/200001/masters/master.tryserv...
masters/master.tryserver.chromium.linux/slaves.cfg:214: 'pool': 'linux_cq',
Please use a unique pool name. Maybe 'linux_trusty'?

Note not all of these builders are on CQ, so there should be a TODO to further
split this pool into CQ and optional one. For testing a single pool is okay.

[Yoshisato Yanagisawa, 2016-11-15 04:00:45]

https://codereview.chromium.org/2357493005/diff/200001/masters/master.chromiu...
File masters/master.chromium.linux/master_linux_cfg.py (right):

https://codereview.chromium.org/2357493005/diff/200001/masters/master.chromiu...
masters/master.chromium.linux/master_linux_cfg.py:41: 'Blimp Linux (dbg)',
On 2016/11/14 09:41:34, Paweł Hajdan Jr. wrote:
> Could you also add Trusty one for Blimp?
> 
> I'd be fine with a TODO in this CL to keep things moving.

Since it is actually trusty, we do not need to do that.
let me add TODO to rename Blimp to trusty.

https://codereview.chromium.org/2357493005/diff/200001/masters/master.tryserv...
File masters/master.tryserver.chromium.linux/slaves.cfg (right):

https://codereview.chromium.org/2357493005/diff/200001/masters/master.tryserv...
masters/master.tryserver.chromium.linux/slaves.cfg:214: 'pool': 'linux_cq',
On 2016/11/14 09:41:34, Paweł Hajdan Jr. wrote:
> Please use a unique pool name. Maybe 'linux_trusty'?
> 
> Note not all of these builders are on CQ, so there should be a TODO to further
> split this pool into CQ and optional one. For testing a single pool is okay.

Done.

[Yoshisato Yanagisawa, 2016-11-15 04:00:51]

The CQ bit was checked by yyanagisawa@chromium.org

[Yoshisato Yanagisawa, 2016-11-15 04:00:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
phajdan.jr@chromium.org
Link to the patchset: https://codereview.chromium.org/2357493005/#ps240001
(title: "rebased")

[commit-bot: I haz the power, 2016-11-15 04:00:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 04:12:40]

Description was changed from

==========
Add trusty builders / testers on chromium.linux and tryserver.chromium.linux

BUG=644641
BUG=646285
BUG=640638
==========

to

==========
Add trusty builders / testers on chromium.linux and tryserver.chromium.linux

BUG=644641
BUG=646285
BUG=640638

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/5a574e8e30189b6fd85d...
==========

[commit-bot: I haz the power, 2016-11-15 04:12:42]

Committed patchset #13 (id:240001) as
https://chromium.googlesource.com/chromium/tools/build/+/5a574e8e30189b6fd85d...