Fix a memory leak found by clang static analyzer.

Fix a memory leak found by clang static analyzer.

The function CFUUIDCreate respect the "Create Rule" for ownership
of the returned reference, so it need to be released by a call to
CFRelease.

BUG=648210
Committed: https://crrev.com/5e5f2f83e084fd34138ed1bf96bf9e39c3f83be2
Cr-Commit-Position: refs/heads/master@{#420020}

[sdefresne, 2016-09-20 16:23:44]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 16:24:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-09-20 16:24:08]

sdefresne@chromium.org changed reviewers:
+ eugenebut@chromium.org

[sdefresne, 2016-09-20 16:24:08]

Please take a look.

[sdefresne, 2016-09-20 16:28:30]

The CQ bit was unchecked by sdefresne@chromium.org

[Eugene But (OOO till 7-30), 2016-09-20 21:59:40]

lgtm

https://codereview.chromium.org/2357463003/diff/1/ios/web/navigation/crw_sess...
File ios/web/navigation/crw_session_controller.mm (right):

https://codereview.chromium.org/2357463003/diff/1/ios/web/navigation/crw_sess...
ios/web/navigation/crw_session_controller.mm:846: CFRelease(uuidRef);
How about simply: |return [NSUUID NSUUID].UUIDString;|

[sdefresne, 2016-09-21 09:19:08]

https://codereview.chromium.org/2357463003/diff/1/ios/web/navigation/crw_sess...
File ios/web/navigation/crw_session_controller.mm (right):

https://codereview.chromium.org/2357463003/diff/1/ios/web/navigation/crw_sess...
ios/web/navigation/crw_session_controller.mm:846: CFRelease(uuidRef);
On 2016/09/20 21:59:40, Eugene But wrote:
> How about simply: |return [NSUUID NSUUID].UUIDString;|

I'll leave this to you as owners of the code to decide whether you want to
rewrite it from using CoreFoundation to using NS objects.

[sdefresne, 2016-09-21 09:19:11]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2016-09-21 09:19:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 09:25:11]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-21 09:28:42]

Description was changed from

==========
Fix a memory leak found by clang static analyzer.

The function CFUUIDCreate respect the "Create Rule" for ownership
of the returned reference, so it need to be released by a call to
CFRelease.

BUG=648210
==========

to

==========
Fix a memory leak found by clang static analyzer.

The function CFUUIDCreate respect the "Create Rule" for ownership
of the returned reference, so it need to be released by a call to
CFRelease.

BUG=648210

Committed: https://crrev.com/5e5f2f83e084fd34138ed1bf96bf9e39c3f83be2
Cr-Commit-Position: refs/heads/master@{#420020}
==========

[commit-bot: I haz the power, 2016-09-21 09:28:43]

Patchset 1 (id:??) landed as
https://crrev.com/5e5f2f83e084fd34138ed1bf96bf9e39c3f83be2
Cr-Commit-Position: refs/heads/master@{#420020}