Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Unified Diff: ios/web/navigation/crw_session_controller.mm

Issue 2357463003: Fix a memory leak found by clang static analyzer. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/navigation/crw_session_controller.mm
diff --git a/ios/web/navigation/crw_session_controller.mm b/ios/web/navigation/crw_session_controller.mm
index c5078c9d9e8d4d4df37908eaf4af2722133887ab..ff1093b43781781ba5eac0e190de40127bde9325 100644
--- a/ios/web/navigation/crw_session_controller.mm
+++ b/ios/web/navigation/crw_session_controller.mm
@@ -843,6 +843,8 @@ NSString* const kXCallbackParametersKey = @"xCallbackParameters";
- (NSString*)uniqueID {
CFUUIDRef uuidRef = CFUUIDCreate(NULL);
CFStringRef uuidStringRef = CFUUIDCreateString(NULL, uuidRef);
+ CFRelease(uuidRef);
Eugene But (OOO till 7-30) 2016/09/20 21:59:40 How about simply: |return [NSUUID NSUUID].UUIDStri
sdefresne 2016/09/21 09:19:08 I'll leave this to you as owners of the code to de
+
NSString* uuid =
[NSString stringWithString:base::mac::ObjCCastStrict<NSString>(
CFBridgingRelease(uuidStringRef))];
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698