Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2357433003: Handle string interpolation/juxtaposition in kernel_impact. (Closed)

Created:
4 years, 3 months ago by Johnni Winther
Modified:
4 years, 3 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle string interpolation/juxtaposition in kernel_impact. R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/7ea9f8b8bc0c0b4577830ceea7fef0822bb79bc3

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -13 lines) Patch
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_impact.dart View 3 chunks +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 2 chunks +0 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_impact.dart View 3 chunks +8 lines, -5 lines 2 comments Download
M tests/compiler/dart2js/kernel/impact_test.dart View 4 chunks +44 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years, 3 months ago (2016-09-20 13:54:42 UTC) #2
Harry Terkelsen
lgtm https://codereview.chromium.org/2357433003/diff/1/pkg/compiler/lib/src/ssa/kernel_impact.dart File pkg/compiler/lib/src/ssa/kernel_impact.dart (left): https://codereview.chromium.org/2357433003/diff/1/pkg/compiler/lib/src/ssa/kernel_impact.dart#oldcode268 pkg/compiler/lib/src/ssa/kernel_impact.dart:268: void visitNot(ir.Not not) { why get rid of ...
4 years, 3 months ago (2016-09-20 18:00:18 UTC) #3
Johnni Winther
https://codereview.chromium.org/2357433003/diff/1/pkg/compiler/lib/src/ssa/kernel_impact.dart File pkg/compiler/lib/src/ssa/kernel_impact.dart (left): https://codereview.chromium.org/2357433003/diff/1/pkg/compiler/lib/src/ssa/kernel_impact.dart#oldcode268 pkg/compiler/lib/src/ssa/kernel_impact.dart:268: void visitNot(ir.Not not) { On 2016/09/20 18:00:18, Harry Terkelsen ...
4 years, 3 months ago (2016-09-21 08:33:40 UTC) #4
Johnni Winther
4 years, 3 months ago (2016-09-21 08:45:04 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
7ea9f8b8bc0c0b4577830ceea7fef0822bb79bc3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698