Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Unified Diff: pkg/compiler/lib/src/ssa/kernel_impact.dart

Issue 2357433003: Handle string interpolation/juxtaposition in kernel_impact. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/resolution/members.dart ('k') | tests/compiler/dart2js/kernel/impact_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/ssa/kernel_impact.dart
diff --git a/pkg/compiler/lib/src/ssa/kernel_impact.dart b/pkg/compiler/lib/src/ssa/kernel_impact.dart
index 15efe23e8b2da8e019c868e3dae9b1b49672008c..fef8f82a6282ad237893285a679b9207ed255810 100644
--- a/pkg/compiler/lib/src/ssa/kernel_impact.dart
+++ b/pkg/compiler/lib/src/ssa/kernel_impact.dart
@@ -5,6 +5,7 @@
import 'package:kernel/ast.dart' as ir;
import '../common.dart';
+import '../common/names.dart';
import '../compiler.dart';
import '../constants/expressions.dart';
import '../dart_types.dart';
@@ -265,11 +266,6 @@ class KernelImpactBuilder extends ir.Visitor {
}
@override
- void visitNot(ir.Not not) {
Harry Terkelsen 2016/09/20 18:00:18 why get rid of this?
Johnni Winther 2016/09/21 08:33:40 It was copied from the ssa builder, but after addi
- not.operand.accept(this);
- }
-
- @override
void visitAssertStatement(ir.AssertStatement node) {
impactBuilder.registerFeature(
node.message != null ? Feature.ASSERT_WITH_MESSAGE : Feature.ASSERT);
@@ -277,5 +273,12 @@ class KernelImpactBuilder extends ir.Visitor {
}
@override
+ void visitStringConcatenation(ir.StringConcatenation node) {
+ impactBuilder.registerFeature(Feature.STRING_INTERPOLATION);
+ impactBuilder.registerFeature(Feature.STRING_JUXTAPOSITION);
+ node.visitChildren(this);
+ }
+
+ @override
void defaultNode(ir.Node node) => node.visitChildren(this);
}
« no previous file with comments | « pkg/compiler/lib/src/resolution/members.dart ('k') | tests/compiler/dart2js/kernel/impact_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698