bluetooth: Add device list retrieval for chrome://bluetooth-internals

chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals.mojom

Index: chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals.mojom
diff --git a/chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals.mojom b/chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals.mojom
new file mode 100644
index 0000000000000000000000000000000000000000..d0bb236b7803779dafa2f2ab497ca164ac8e41b3
--- /dev/null
+++ b/chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals.mojom
@@ -0,0 +1,13 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+module mojom;
+
+import "device/bluetooth/public/interfaces/bluetooth.mojom";
+
+interface InternalsPageHandler {

[ortuno, 2016/09/26 01:57:56]

This is not in the bluetooth module so I believe it should be named
BluetoothInternalsPageHandler.

[mbrunson, 2016/09/28 02:18:22]

Done.

+  // Creates pipe for Bluetooth Adapter between |client| and |adapter|
+  GetAdapterService(bluetooth.mojom.Adapter& adapter,

[ortuno, 2016/09/26 01:57:56]

Sorry, what you had before was ok. I should have been clearer. I was thinking
that it might not be necessary to go through the internals page to get the
adapter. It might be possible to register the adapter service here[1] and then
just retrieve it in bluetooth_internals.js with:

adapterService = connection.bindHandleToProxy(
  frameInterfaces.getInterface(mojom.bluetooth.Adapter.name),
  mojom.bluetooth.Adapter);

Note that this will mean that we have to set the client separately. I think this
is the right way forward given that this will end up being how every client will
retrieve the adapter service but I don't think it's a big deal for now.

Anyway it's just something to explore. What you had before was fine. In case I
wasn't clear or if you have any questions I made a POC patch that implements
this pattern https://codereview.chromium.org/2372433002 check
bluetooth_internals.js, chrome_content_browser_client.cc and
bluetooth_adapter_service.h/cc

[1]
https://cs.chromium.org/chromium/src/chrome/browser/chrome_content_browser_cl...

[mbrunson, 2016/09/28 02:18:22]

I agree. Decoupling the adapter service from the WebUI is a better way of doing
it. This is the original idea I had, but I wasn't sure where the adapter service
would be created, who would own it, and what its lifetime would be. Doing it
your way greatly simplifies the WebUI and JS code and removes many changes from
this patch.

+                    bluetooth.mojom.AdapterClient client);
+};