chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals.mojom - Issue 2357383002: bluetooth: Add device list retrieval for chrome://bluetooth-internals

Side by Side Diff: chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals.mojom

Issue 2357383002: bluetooth: Add device list retrieval for chrome://bluetooth-internals (Closed)

Patch Set: Mojo interface and implementation fixes Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« chrome/browser/resources/bluetooth_internals/bluetooth_internals.js ('K') | « chrome/browser/ui/webui/bluetooth_internals/OWNERS ('k') | chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_ui.h » ('j') | chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_ui.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module mojom;

	6

	7 import "device/bluetooth/public/interfaces/bluetooth.mojom";

	8

	9 interface InternalsPageHandler {
	ortuno 2016/09/26 01:57:56 This is not in the bluetooth module so I believe i This is not in the bluetooth module so I believe it should be named BluetoothInternalsPageHandler. mbrunson 2016/09/28 02:18:22 Done. Show quoted text On 2016/09/26 01:57:56, ortuno wrote: > This is not in the bluetooth module so I believe it should be named > BluetoothInternalsPageHandler. Done.
	10 // Creates pipe for Bluetooth Adapter between \|client\| and \|adapter\|

	11 GetAdapterService(bluetooth.mojom.Adapter& adapter,
	ortuno 2016/09/26 01:57:56 Sorry, what you had before was ok. I should have b Sorry, what you had before was ok. I should have been clearer. I was thinking that it might not be necessary to go through the internals page to get the adapter. It might be possible to register the adapter service here[1] and then just retrieve it in bluetooth_internals.js with: adapterService = connection.bindHandleToProxy( frameInterfaces.getInterface(mojom.bluetooth.Adapter.name), mojom.bluetooth.Adapter); Note that this will mean that we have to set the client separately. I think this is the right way forward given that this will end up being how every client will retrieve the adapter service but I don't think it's a big deal for now. Anyway it's just something to explore. What you had before was fine. In case I wasn't clear or if you have any questions I made a POC patch that implements this pattern https://codereview.chromium.org/2372433002 check bluetooth_internals.js, chrome_content_browser_client.cc and bluetooth_adapter_service.h/cc [1] https://cs.chromium.org/chromium/src/chrome/browser/chrome_content_browser_cl... mbrunson 2016/09/28 02:18:22 I agree. Decoupling the adapter service from the W Show quoted text On 2016/09/26 01:57:56, ortuno wrote: > Sorry, what you had before was ok. I should have been clearer. I was thinking > that it might not be necessary to go through the internals page to get the > adapter. It might be possible to register the adapter service here[1] and then > just retrieve it in bluetooth_internals.js with: > > adapterService = connection.bindHandleToProxy( > frameInterfaces.getInterface(mojom.bluetooth.Adapter.name), > mojom.bluetooth.Adapter); > > Note that this will mean that we have to set the client separately. I think this > is the right way forward given that this will end up being how every client will > retrieve the adapter service but I don't think it's a big deal for now. > > Anyway it's just something to explore. What you had before was fine. In case I > wasn't clear or if you have any questions I made a POC patch that implements > this pattern https://codereview.chromium.org/2372433002 check > bluetooth_internals.js, chrome_content_browser_client.cc and > bluetooth_adapter_service.h/cc > > [1] > https://cs.chromium.org/chromium/src/chrome/browser/chrome_content_browser_cl... I agree. Decoupling the adapter service from the WebUI is a better way of doing it. This is the original idea I had, but I wasn't sure where the adapter service would be created, who would own it, and what its lifetime would be. Doing it your way greatly simplifies the WebUI and JS code and removes many changes from this patch.
	12 bluetooth.mojom.AdapterClient client);

	13 };

OLD	NEW