chromium_tests: automatically set up test genrators

chromium_tests: automatically set up test generators

BUG=none

Committed: https://chromium.googlesource.com/chromium/tools/build/+/5aec3d0b7c32994f52910decfb244f91845fd858

[Paweł Hajdan Jr., 2016-09-22 21:54:46]

phajdan.jr@chromium.org changed reviewers:
+ stip@chromium.org

[Paweł Hajdan Jr., 2016-09-22 21:55:17]

Description was changed from

==========
chromium_tests: automatically set up test genrators

BUG=none
==========

to

==========
chromium_tests: automatically set up test generators

BUG=none
==========

[ghost stip (do not use), 2016-09-22 23:24:07]

Description was changed from

==========
chromium_tests: automatically set up test generators

BUG=none
==========

to

==========
chromium_tests: automatically set up test generators

BUG=none
==========

[ghost stip (do not use), 2016-09-22 23:25:50]

lgtm, this is awesome!

I've tagged as many owners as I could ascertain. I don't see this change
affecting anything, but we're making fundamental changes to the bots here and
I'd rather not catch people off-guard. Please tag people when making future
builder changes like this.

Thanks again for helping to clean up steps.py :)

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/api.py (right):

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/api.py:230: # TODO(phajdan.jr):
Switch everything to scripts generators and simplify.
:D

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/api.py:237: tuple(tests))
did this not work before?

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py
(right):

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py:71: #
TODO(phajdan.jr): Bots should have no generators instead.
should we remove this todo?

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_chromiumos.py (left):

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_chromiumos.py:99:
steps.generate_gtest,
dnj: fyi, this shouldn't affect anything

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py (left):

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:1: # Copyright 2014
The Chromium Authors. All rights reserved.
so many dang owners of these builders :(

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:52:
steps.generate_gtest,
smut: fyi, this shouldn't affect anything

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:86:
steps.generate_gtest,
justincohen: fyi, shouldn't affect anything

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:109:
steps.generate_gtest,
sbc: fyi, shouldn't affect anything

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:152:
steps.generate_gtest,
qyearsley: fyi, this shouldn't affect anything

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:178:
steps.generate_gtest,
dcampb: fyi, shouldn't affect anything

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:204:
steps.generate_gtest,
machenbach: fyi, shouldn't affect anything

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:338:
steps.generate_gtest,
krasin: fyi, shouldn't affect anything

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:516:
steps.generate_gtest,
alexmos: fyi, shouldn't affect anything

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:580:
steps.generate_gtest,
clamy: fyi, shouldn't affect anything

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:621:
steps.generate_gtest,
thakis: fyi, shouldn't affect anything

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:1899:
steps.generate_gtest,
kbr: fyi, shouldn't affect anything

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:1922:
steps.generate_gtest,
perezju: fyi, shouldn't affect anything

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:1966:
steps.generate_gtest,
jbudorick: fyi, shouldn't affect anything

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:2160:
steps.generate_gtest,
bsheedy: fyi, shouldn't affect anything

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:2231:
steps.generate_gtest,
msw: fyi, shouldn't affect anything

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_gpu.py (left):

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_gpu.py:71:
steps.generate_gtest,
kbr: fyi, this shouldn't affect anything

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py (left):

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py:77:
steps.generate_gtest,
kbr: fyi, this shouldn't affect anything

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_memory.py (left):

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_memory.py:43:
steps.generate_gtest,
eugenis: fyi, this shouldn't affect anything

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_memory_full.py (left):

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_memory_full.py:37:
steps.generate_gtest,
eugenis: fyi, this shouldn't affect anything

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_perf.py (left):

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_perf.py:99:
spec['test_generators'] = [steps.generate_script]
dtu: fyi, this shouldn't affect anything

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py (left):

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py:55:
spec['test_generators'] = [steps.generate_isolated_script]
dtu: fyi, this shouldn't affect anything

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_webkit.py (left):

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_webkit.py:42:
steps.generate_gtest,
dpranke: fyi, this shouldn't affect anything

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py (left):

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py:94:
steps.generate_gtest,
kjellander: fyi, this shouldn't affect anything

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/client_v8_fyi.py (left):

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/client_v8_fyi.py:106:
steps.generate_gtest,
machenbach: fyi, this shouldn't affect anything

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipes/chrom...
File
scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClangGoma.json
(right):

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipes/chrom...
scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClangGoma.json:302:
"--clean-isolated-files"
I guess these were added because the test data provided some swarmed target?

[dtu, 2016-09-22 23:41:23]

dtu@chromium.org changed reviewers:
+ dtu@chromium.org

[dtu, 2016-09-22 23:41:23]

cool.

[Dirk Pranke, 2016-09-22 23:50:43]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-09-22 23:50:44]

lgtm, nice change.

[jbudorick, 2016-09-22 23:55:10]

On 2016/09/22 23:41:23, dtu wrote:
> cool.

+1

Thanks for the heads up!

[Ken Russell (switch to Gerrit), 2016-09-23 00:33:40]

kbr@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2016-09-23 00:33:40]

Good simplification! Non-owner LGTM.

[Paweł Hajdan Jr., 2016-09-23 01:14:54]

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/api.py (right):

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/api.py:237: tuple(tests))
On 2016/09/22 at 23:25:48, stip wrote:
> did this not work before?

Bots where this doesn't work (they use frozenset) were not using test
generators.

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py
(right):

https://codereview.chromium.org/2357343004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py:71: #
TODO(phajdan.jr): Bots should have no generators instead.
On 2016/09/22 at 23:25:48, stip wrote:
> should we remove this todo?

Good point. I updated it.

[perezju, 2016-09-23 08:53:03]

perezju@chromium.org changed reviewers:
+ perezju@chromium.org

[perezju, 2016-09-23 08:53:03]

thanks for the heads up!

[Michael Achenbach, 2016-09-23 13:54:31]

machenbach@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Achenbach, 2016-09-23 13:54:31]

v8 lgtm

[clamy, 2016-09-23 13:57:41]

clamy@chromium.org changed reviewers:
+ clamy@chromium.org

[clamy, 2016-09-23 13:57:42]

Thanks for the head up! It looks like a nice simplification.

[ghost stip (do not use), 2016-09-23 20:01:48]

phajdan: when are you planning on landing this?

[Paweł Hajdan Jr., 2016-09-26 21:14:01]

On 2016/09/23 at 20:01:48, stip wrote:
> phajdan: when are you planning on landing this?

I was originally planning for today, but this is getting postponed because of
https://bugs.chromium.org/p/chromium/issues/detail?id=634418 .

[Paweł Hajdan Jr., 2016-09-27 18:36:24]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 18:36:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 18:40:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 18:40:40]

Dry run: This issue passed the CQ dry run.

[Paweł Hajdan Jr., 2016-09-28 21:19:49]

The CQ bit was checked by phajdan.jr@chromium.org

[Paweł Hajdan Jr., 2016-09-28 21:19:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, stip@chromium.org, kbr@chromium.org,
machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/2357343004/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-28 21:19:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 21:23:56]

Description was changed from

==========
chromium_tests: automatically set up test generators

BUG=none
==========

to

==========
chromium_tests: automatically set up test generators

BUG=none

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/5aec3d0b7c32994f5291...
==========

[commit-bot: I haz the power, 2016-09-28 21:23:58]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/tools/build/+/5aec3d0b7c32994f5291...