chromium_tests: automatically set up test genrators

scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import ast
 import copy
 
 from recipe_engine.types import freeze
 
 
@@ skipping 50 matching lines @@
 
     test_spec_file = self.get('testing', {}).get(
         'test_spec_file', '%s.json' % mastername)
 
     # TODO(phajdan.jr): Bots should have no generators instead.
     if self.get('disable_tests'):
       return {}
     return chromium_tests_api.read_test_spec(chromium_tests_api.m, test_spec_file)
 
   def initialize_bot_db(self, chromium_tests_api, bot_db, bot_update_step):
     # TODO(phajdan.jr): Bots should have no generators instead.

[ghost stip (do not use), 2016/09/22 23:25:48]

should we remove this todo?

[Paweł Hajdan Jr., 2016/09/23 01:14:54]

Good point. I updated it.

     if self.get('disable_tests'):
       scripts_compile_targets = {}
     else:
       scripts_compile_targets = \
           chromium_tests_api.get_compile_targets_for_scripts().json.output
 
+    test_generators = [
+      chromium_tests_api.steps.generate_gtest,
+      chromium_tests_api.steps.generate_instrumentation_test,
+      chromium_tests_api.steps.generate_junit_test,
+      chromium_tests_api.steps.generate_script,
+      chromium_tests_api.steps.generate_isolated_script,
+    ]
+
     masternames = set(bot_id['mastername'] for bot_id in self._bot_ids)
     for mastername in sorted(self._bots_dict):
       # We manually thaw the path to the elements we are modifying, since the
       # builders are frozen.
       master_dict = dict(self._bots_dict[mastername])
 
       if mastername in masternames:
         test_spec = self._get_test_spec(chromium_tests_api, mastername)
 
         builders = master_dict['builders'] = dict(master_dict['builders'])
         for loop_buildername in builders:
           builder_dict = builders[loop_buildername] = (
               dict(builders[loop_buildername]))
           builders[loop_buildername]['tests'] = (
               chromium_tests_api.generate_tests_from_test_spec(
                   chromium_tests_api.m, test_spec, builder_dict,
                   loop_buildername, mastername,
                   # TODO(phajdan.jr): Get enable_swarming value from
                   # builder_dict. Above should remove the need to get
                   # bot_config and buildername in this method.
                   self.get('enable_swarming', False),
                   builder_dict.get('swarming_dimensions', {}),
                   scripts_compile_targets,
-                  builder_dict.get('test_generators', []),
+                  test_generators,
                   bot_update_step
               ))
       else:
         test_spec = None
 
 
       bot_db._add_master_dict_and_test_spec(
           mastername, freeze(master_dict), freeze(test_spec))
 
   def get_tests(self, bot_db):
@@ skipping 85 matching lines @@
           'builders', {}).iteritems():
         master_matches = (bot_config.get('parent_mastername', mastername) ==
                           parent_mastername)
         builder_matches = (bot_config.get('parent_buildername') ==
                            parent_buildername)
         if master_matches and builder_matches:
           yield mastername, buildername, bot_config
 
   def get_test_spec(self, mastername, buildername):
     return self._db[mastername]['test_spec'].get(buildername, {})