Add output format properties to SkImageFilter::Context

Add output format properties to SkImageFilter::Context

For now, this is just the color space (of the original
requesting device). This is used when constructing
intermediate rendering surfaces, so that we ensure we
land in a surface that's similar/compatible to the
final consumer of the DAG's output.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2357273002

Committed: https://skia.googlesource.com/skia/+/2a75e5df300a2838f943ca52a52a85a5cf69802b

[Brian Osman, 2016-09-21 15:09:57]

Description was changed from

==========
Add destination color space to SkImageFilter::Context

BUG=skia:
==========

to

==========
Add destination color space to SkImageFilter::Context

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2357273002
==========

[Brian Osman, 2016-09-21 18:18:05]

Description was changed from

==========
Add destination color space to SkImageFilter::Context

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2357273002
==========

to

==========
Add output format properties to SkImageFilter::Context

For now, this is just the color space (of the original
requesting device). This is used when constructing
intermediate rendering surfaces, so that we ensure we
land in a surface that's similar/compatible to the
final consumer of the DAG's output.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2357273002
==========

[Brian Osman, 2016-09-21 18:29:40]

brianosman@google.com changed reviewers:
+ bsalomon@google.com, reed@google.com, robertphillips@google.com

[Brian Osman, 2016-09-21 18:30:17]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 18:30:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[robertphillips, 2016-09-21 18:44:09]

lgtm

https://codereview.chromium.org/2357273002/diff/40001/include/core/SkImageFil...
File include/core/SkImageFilter.h (right):

https://codereview.chromium.org/2357273002/diff/40001/include/core/SkImageFil...
include/core/SkImageFilter.h:36: public:
// Basically copy your CL's comment here - why is this class here

?

https://codereview.chromium.org/2357273002/diff/40001/include/core/SkImageFil...
include/core/SkImageFilter.h:38: public:
can this fit on one line?

Maybe a comment here about why it's okay to just have a bare pointer here ?

https://codereview.chromium.org/2357273002/diff/40001/src/core/SkBitmapDevice...
File src/core/SkBitmapDevice.cpp (right):

https://codereview.chromium.org/2357273002/diff/40001/src/core/SkBitmapDevice...
src/core/SkBitmapDevice.cpp:397: SkAutoTUnref<SkImageFilterCache>
cache(this->getImageFilterCache());
Don't we have to be a bit more careful here and always pass a null color space
(for now) ?

https://codereview.chromium.org/2357273002/diff/40001/src/pdf/SkPDFDevice.cpp
File src/pdf/SkPDFDevice.cpp (right):

https://codereview.chromium.org/2357273002/diff/40001/src/pdf/SkPDFDevice.cpp...
src/pdf/SkPDFDevice.cpp:2292: // in the same color space as the source (this is
different from all other backends).
nullptr here too ?

[robertphillips, 2016-09-21 18:44:18]

The CQ bit was unchecked by robertphillips@google.com

[Brian Osman, 2016-09-21 19:00:32]

Testing locally to ensure that nothing explodes in either backend...

https://codereview.chromium.org/2357273002/diff/40001/include/core/SkImageFil...
File include/core/SkImageFilter.h (right):

https://codereview.chromium.org/2357273002/diff/40001/include/core/SkImageFil...
include/core/SkImageFilter.h:36: public:
On 2016/09/21 18:44:09, robertphillips wrote:
> // Basically copy your CL's comment here - why is this class here
> 
> ?

Done.

https://codereview.chromium.org/2357273002/diff/40001/include/core/SkImageFil...
include/core/SkImageFilter.h:38: public:
On 2016/09/21 18:44:09, robertphillips wrote:
> can this fit on one line?
> 
> Maybe a comment here about why it's okay to just have a bare pointer here ?

Done.

https://codereview.chromium.org/2357273002/diff/40001/src/core/SkBitmapDevice...
File src/core/SkBitmapDevice.cpp (right):

https://codereview.chromium.org/2357273002/diff/40001/src/core/SkBitmapDevice...
src/core/SkBitmapDevice.cpp:397: SkAutoTUnref<SkImageFilterCache>
cache(this->getImageFilterCache());
On 2016/09/21 18:44:09, robertphillips wrote:
> Don't we have to be a bit more careful here and always pass a null color space
> (for now) ?

This doesn't actually do anything to the raster backend yet - until I change the
behavior of makeSurface. Thinking I'll put the temporary short-circuit in
SkSpecialImage_Raster::onMakeSurface when I make that change, so it's in one
place.

[Brian Osman, 2016-09-21 20:28:56]

... seems okay. Four GMs changed behavior between GPU
sRGB and F16 configs (and one was a regression), but
those results should all improve dramatically when I
make the upcoming change to makeSurface. lgty?

[Brian Osman, 2016-09-21 20:49:32]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 20:49:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 21:25:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 21:25:09]

Dry run: This issue passed the CQ dry run.

[Brian Osman, 2016-09-22 13:22:08]

bsalomon@ / reed@, this has some (not really public) API changes. Tempted to
TBR, but I'd like to get a thumbs up.

[bsalomon, 2016-09-22 13:52:53]

I defer to reed@, not so well versed on SkIF intricacies.

[Brian Osman, 2016-09-22 14:14:09]

The CQ bit was checked by brianosman@google.com

[Brian Osman, 2016-09-22 14:14:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2357273002/#ps100001
(title: "Spelling")

[reed1, 2016-09-22 14:14:15]

api lgtm

lets find a way to fission this into

SkImageFilter -- no api
SkImageFilter_Bbase -- all the virtual/context crap

(in a later CL)

[commit-bot: I haz the power, 2016-09-22 14:14:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 14:15:39]

Description was changed from

==========
Add output format properties to SkImageFilter::Context

For now, this is just the color space (of the original
requesting device). This is used when constructing
intermediate rendering surfaces, so that we ensure we
land in a surface that's similar/compatible to the
final consumer of the DAG's output.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2357273002
==========

to

==========
Add output format properties to SkImageFilter::Context

For now, this is just the color space (of the original
requesting device). This is used when constructing
intermediate rendering surfaces, so that we ensure we
land in a surface that's similar/compatible to the
final consumer of the DAG's output.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2357273002

Committed:
https://skia.googlesource.com/skia/+/2a75e5df300a2838f943ca52a52a85a5cf69802b
==========

[commit-bot: I haz the power, 2016-09-22 14:15:40]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/2a75e5df300a2838f943ca52a52a85a5cf69802b