Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 2357173003: Revert of Add CHECKs to investigate ResourceThrottle crash. (Closed)

Created:
4 years, 3 months ago by mmenke
Modified:
4 years, 3 months ago
Reviewers:
Charlie Harrison
CC:
chromium-reviews, asanka, jam, Randy Smith (Not in Mondays), darin-cc_chromium.org, loading-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add CHECKs to investigate ResourceThrottle crash. (patchset #11 id:280001 of https://codereview.chromium.org/2271403002/ ) Reason for revert: Figured out the issue, these are no longer needed. Original issue's description: > Add CHECKs to investigate ResourceThrottle crash. > > BUG=640545 > > Committed: https://crrev.com/25d0501e6e9cf23cda9ea26a1b380dbbb4db0ba3 > Cr-Commit-Position: refs/heads/master@{#414899} TBR=csharrison@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=640545 Committed: https://crrev.com/c25b23acf5c133b941ee35cb7a0e32b1e539dfbd Cr-Commit-Position: refs/heads/master@{#420151}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -45 lines) Patch
M content/browser/loader/throttling_resource_handler.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/loader/throttling_resource_handler.cc View 9 chunks +1 line, -40 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mmenke
Created Revert of Add CHECKs to investigate ResourceThrottle crash.
4 years, 3 months ago (2016-09-21 19:46:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2357173003/1
4 years, 3 months ago (2016-09-21 19:46:26 UTC) #3
Charlie Harrison
LGTM
4 years, 3 months ago (2016-09-21 19:47:47 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 20:28:55 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 20:31:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c25b23acf5c133b941ee35cb7a0e32b1e539dfbd
Cr-Commit-Position: refs/heads/master@{#420151}

Powered by Google App Engine
This is Rietveld 408576698