Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2357163002: Setting the link title may change the preferred set. (Closed)

Created:
4 years, 3 months ago by rune
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Setting the link title may change the preferred set. Make sure we set the preferred style sheet set when setting the title attribute as long as the preferred set name is not already set. This used to somehow work if the title was set during loading of a stylesheet since the preferred set name was set during active stylesheet collection. In other cases, it didn't work until another stylesheet operation caused a re-collection of active stylesheets. When setting the preferred name was moved into the LinkStyle::process() code, it didn't work at all to set the title after the stylesheet starts loading. Make sure we set the preferred set name and trigger an active stylesheet update when the title is changed. BUG=645699 Review-Url: https://codereview.chromium.org/2337193004 Cr-Commit-Position: refs/heads/master@{#419107} (cherry picked from commit eda0b8d43b6ee62b68639bb10b9a0f76333a3304) Conflicts: third_party/WebKit/Source/core/html/HTMLLinkElement.h Committed: https://chromium.googlesource.com/chromium/src/+/7afc70c366cbd7fcb0ae9f0e767e6a35ccb5ea40

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -18 lines) Patch
A third_party/WebKit/LayoutTests/fast/css/change-title-enabling-alternate.html View 1 chunk +41 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 4 chunks +12 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLinkElement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLinkElement.cpp View 5 chunks +16 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
rune
4 years, 3 months ago (2016-09-21 12:37:13 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7afc70c366cbd7fcb0ae9f0e767e6a35ccb5ea40.

Powered by Google App Engine
This is Rietveld 408576698