Setting the link title may change the preferred set.

Setting the link title may change the preferred set.

Make sure we set the preferred style sheet set when setting the title
attribute as long as the preferred set name is not already set.

This used to somehow work if the title was set during loading of a
stylesheet since the preferred set name was set during active
stylesheet collection. In other cases, it didn't work until another
stylesheet operation caused a re-collection of active stylesheets.

When setting the preferred name was moved into the LinkStyle::process()
code, it didn't work at all to set the title after the stylesheet
starts loading.

Make sure we set the preferred set name and trigger an active
stylesheet update when the title is changed.

BUG=645699
Committed: https://crrev.com/eda0b8d43b6ee62b68639bb10b9a0f76333a3304
Cr-Commit-Position: refs/heads/master@{#419107}

[rune, 2016-09-14 12:27:21]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 12:27:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 14:05:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 14:05:20]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[rune, 2016-09-14 17:16:37]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 17:18:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 19:21:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 19:21:09]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[rune, 2016-09-15 10:32:26]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 10:32:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 11:27:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 11:27:23]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[rune, 2016-09-15 12:44:50]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 12:45:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 14:12:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 14:12:28]

Dry run: This issue passed the CQ dry run.

[rune, 2016-09-15 14:20:08]

rune@opera.com changed reviewers:
+ timloh@chromium.org, yoav@yoav.ws

[rune, 2016-09-15 14:20:08]

ptal

timloh/yoav, you reviewed the offending CL [1].

[1] https://codereview.chromium.org/2079303002

[Timothy Loh, 2016-09-16 03:46:52]

On 2016/09/15 14:20:08, rune wrote:
> ptal
> 
> timloh/yoav, you reviewed the offending CL [1].
> 
> [1] https://codereview.chromium.org/2079303002

lgtm, but as before I'm not really familiar with this code

[rune, 2016-09-16 05:46:30]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2016-09-16 05:46:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 05:51:23]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-16 05:53:20]

Description was changed from

==========
Setting the link title may change the preferred set.

Make sure we set the preferred style sheet set when setting the title
attribute as long as the preferred set name is not already set.

This used to somehow work if the title was set during loading of a
stylesheet since the preferred set name was set during active
stylesheet collection. In other cases, it didn't work until another
stylesheet operation caused a re-collection of active stylesheets.

When setting the preferred name was moved into the LinkStyle::process()
code, it didn't work at all to set the title after the stylesheet
starts loading.

Make sure we set the preferred set name and trigger an active
stylesheet update when the title is changed.

BUG=645699
==========

to

==========
Setting the link title may change the preferred set.

Make sure we set the preferred style sheet set when setting the title
attribute as long as the preferred set name is not already set.

This used to somehow work if the title was set during loading of a
stylesheet since the preferred set name was set during active
stylesheet collection. In other cases, it didn't work until another
stylesheet operation caused a re-collection of active stylesheets.

When setting the preferred name was moved into the LinkStyle::process()
code, it didn't work at all to set the title after the stylesheet
starts loading.

Make sure we set the preferred set name and trigger an active
stylesheet update when the title is changed.

BUG=645699

Committed: https://crrev.com/eda0b8d43b6ee62b68639bb10b9a0f76333a3304
Cr-Commit-Position: refs/heads/master@{#419107}
==========

[commit-bot: I haz the power, 2016-09-16 05:53:21]

Patchset 3 (id:??) landed as
https://crrev.com/eda0b8d43b6ee62b68639bb10b9a0f76333a3304
Cr-Commit-Position: refs/heads/master@{#419107}